ChangeLog 340 KB
Newer Older
1
2
3
4
5
6
7
2011-01-12  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix segfault with g++-3.3.

	* src/tgbaalgos/minimize.cc (minimize_dfa): Fix deletion of the
	state_set_map.  It led to a crash when compiled with g++-3.3.

8
9
10
11
12
13
14
15
16
2011-01-12  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix a compilation failure with g++-3.3.

	* src/misc/hash.hh (identity_hash): New function.
	* src/tgba/tgbaexplicit.hh (tgba_explicit_number): Use
	identity_hash<int> instead of std::tr1::hash<int> that does not
	exist with g++-3.3.

17
18
19
20
21
22
23
24
25
26
2011-01-07  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix usage of minimize_obligation in the CGI script.

	* wrap/python/cgi-bin/ltl2tgba.py (reduce_wdba): Use
	minimize_obligation_new a pass the formula.
	* wrap/python/spot.i (minimize_obligation_new): New function, to
	cope with the strange specification of spot::minimize_obligation()
	not always creating a new automaton.

27
28
29
30
2011-01-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* NEWS: Convert to utf-8 and fix a few typos.

31
32
33
34
35
36
37
38
39
40
2011-01-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	'([]a && XXXX!a)' was not properly minimized because its
	translation contain useless SCCs that where not ignored for
	minimization.

	* src/tgbaalgos/minimize.cc (minimize_wdba): Strip useless
	SCCs before minimization.
	* src/tgbatest/ltl2tgba.test: Add a check.

41
42
43
44
45
46
47
48
49
50
51
52
2011-01-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	The neverclaim output by spin -f '([]a && XXXX!a)' was not
	understood by Spot.

	* src/neverparse/neverclaimparse.yy: Support "if :: false fi;"
	instructions.  Spin sometimes output these on dead states.
	Also rewrite the "transitions" rule as a left recursion.
	* src/tgbatest/neverclaimread.test: Adjust output because
	of the right->left recursion change, and add two more formula
	to submit to Spin to test its output.

53
54
55
56
57
58
59
60
61
62
63
2011-01-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Speed up computation of non_final states for minimize_wdba.

	* src/tgbaalgos/minimize.cc (minimize_dfa): Take final and
	non_final sets.
	(minimize_wdba): Fill in non_final at the same time as final.
	(minimize_monitor): Call state_set() to fill non_final.
	(init_sets): Simplify and rename as ...
	(state_set): ... this.

64
65
66
67
68
69
70
71
72
2011-01-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Introduce a class to complement a WDBA on-the-fly.

	* src/tgba/wdbacomp.hh, src/tgba/wdbacomp.cc: New file.
	* src/tgba/Makefile.am: Add them.
	* src/tgbaalgos/minimize.cc (minimize_obligation): Use
	wdba_complement().

73
74
75
76
77
2011-01-05  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbatest/Makefile.am: Remove the unused minimize program.
	* src/tgbatest/minimize.cc: Delete.

78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
2011-01-05  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Cleanup the minimize.hh interface.

	* src/tgbaalgos/minimize.hh, src/tgbaalgos/minimize.cc
	(minimize): Split into ...
	(minimize_wdba, minimize_monitor): ... these two functions.
	* src/tgbatest/ltl2tgba.cc (main): Adjust the call to
	minimize_monitor.
	* wrap/python/cgi-bin/ltl2tgba.in: Adjust the calls to
	minimize_monitor and minimize_obligation.
	* wrap/python/spot.i: Declare minimize_monitor, minimize_wdba,
	minimize_obligations.
	* src/tgba/tgbaexplicit.hh (tgba_explicit_string)
	(tgba_explicit_formula, tgba_explicit_number): Add fake
	declarations so that SWIG can see they inherits from tgba.

95
96
97
98
99
100
101
102
103
104
2011-01-05  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Cleanup the DFA minimization algorithm.

	* src/tgbaalgos/minimize.cc (minimize):  Move the minimization
	code into...
	(minimize_dfa): ... this new function, and fix the condition
	under which a partition is considered to be minimal.  Also
	use a map instead of a list to lookup known formulae.

105
106
107
108
109
110
111
112
2011-01-05  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Speed up the obligation test.

	* src/tgbaalgos/minimize.cc (minimize_obligation): Do not
	minimize aut_neg_f, complement min_aut_f instead.
	* src/tgbaalgos/minimize.hh: Adjust description.

113
114
115
116
117
2011-01-05  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbaalgos/minimize.cc (minimize): Use the Loeding algorithm
	to label transient states.

118
119
2011-01-04  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

120
121
122
123
124
125
126
127
128
129
130
131
132
133
	Rewrite the check of WDBA state acceptance in minimize().

	* src/tgbaalgos/powerset.hh (power_map): New structure, allowing
	the caller to retrieve the set of original states corresponding to
	the set in the deterministic automaton.
	(power_set): Adjust prototype to take a power_map instead of the
	acc_list.
	* src/tgbaalgos/powerset.cc (power_set): Strip all code using
	acc_list, and update power_set.
	* src/tgbaalgos/minimize.cc (minimize): Rewrite, using an
	algorithm similar to the one in the Dax paper to check whether
	state of the minimized automaton should be accepting.

2011-01-04  Alexandre Duret-Lutz  <adl@lrde.epita.fr>
134
135
136
137

	* src/tgbaalgos/scc.hh, src/tgbaalgos/scc.cc (scc_map::trivial,
	scc_map::one_state_of): Two new helper functions.

138
139
140
141
2011-01-04  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgba/tgbaunion.hh: Remove one useless include.

142
143
144
145
2011-01-04  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* README: Mention bench/wdba/.

146
147
148
149
150
151
152
153
2011-01-04  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Define tgba_product_init, a new kind of product with different
	initial states.

	* src/tgba/tgbaproduct.hh, src/tgba/tgbaproduct.cc
	(tgba_product_init): New class.

154
155
156
157
158
159
2011-01-04  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbatest/spotlbtt.test: Add test for -l -R3b, showing many
	failure because the minimization() algorithm is currently
	incorrect when applied to non-weak automata.

160
161
162
163
2011-01-04  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbaalgos/scc.hh: Typo in documentation.

164
165
166
167
168
169
170
171
172
173
2011-01-04  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Move the logic for detecting when the minimize() algorithm is
	correct from ltl2tgba to the library.

	* src/tgbaalgos/minimize.hh,
	src/tgbaalgos/minimize.cc (minimize_obligation): New function.
	* src/tgbatests/ltl2tgba.cc (main): Fix constness of automata,
	and call minimize_obligation() for -R3b.

174
175
176
177
178
179
180
181
182
2010-12-26  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Make minimization of obligation properties and deterministic
	monitor available in the CGI script.

	* wrap/python/spot.i: Declare the minimize() interface.
	* wrap/python/cgi-bin/ltl2tgba.in: Add reduce_dmonitor and
	reduce_wdba options.

Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
183
184
185
186
187
188
189
190
191
2010-12-14  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Add a WDBA benchmark.

	* bench/wdba/: New directory.
	* bench/Makefile.am (SUBDIRS): Add wdba.
	* NEWS: Mention it.
	* configure.ac: Output bench/wdba/defs and bench/wdba/Makefile.

192
193
194
195
2010-12-13  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* NEWS: Update the news about minimization.

196
197
198
199
200
201
202
203
2010-11-26  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Speed up wdba.test, it was too slow for our buildfarm.

	* src/tgbatest/wdba.test: Speed up execution by running only a
	couple of formula with valgrind.  Half of those with`-l -R3b' and
	the other half with `-f -R3'.

204
205
206
207
208
2010-11-26  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbatest/ltl2tgba.cc (syntax): Regroup -M, -s, and -S option
	under the same heading "automaton conversion".

209
210
211
212
213
214
215
216
217
218
2010-11-25  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Preliminary support for monitors.

	* src/tgbatest/ltl2tgba.cc (-M): New option for building
	deterministic monitors.
	* src/tgbaalgos/minimize.cc (minimize): Take a monitor
	argument and adjust the code.
	* src/tgbaalgos/minimize.hh (minimize): Document it.

219
220
221
222
223
224
225
2010-11-25  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	"ltl2tgba -Rm -X foo.tgba" would fail.

	* src/tgbatest/ltl2tgba.cc (main): Warn if -Rm is used without
	knowing the formula whose automaton is minimized.

Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
226
227
228
229
230
231
232
233
234
2010-11-25  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix bugs in minimize().

	* src/tgbaalgos/minimize.cc (init_sets, minimize): Fix memory
	leaks and a usage of the wrong automaton.
	* src/tgbatest/wdba.test: Try using -Rm with -R3 or -R3b, and with
	valgrind.  This caught all the bugs fixed above.

235
236
237
238
239
240
241
242
243
244
2010-04-13  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix bugs in minimize(), caught by spotlbtt.test.

	* src/tgbaalgos/minimize.cc (minimize): Don't add acceptance
	conditions if the final set is empty.
	* src/tgbaalgos/powerset.cc (tgba_powerset): Add the initial state
	to acc_list if it is accepting.  Also do not compute an SCC build
	map if we don't have to build acc_list.

245
246
247
248
249
250
251
252
253
254
255
256
257
258
2010-04-13  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	"ltl2tgba -Rm" will apply WDBA-minimization only if correct.

	* src/tgbatest/ltl2tgba.cc (main): Use WDBA-minimization only when
	it is correct. Either we can quickly determine that a formula or
	its negation is a safety formula, or we can slowly check the
	equivalence of the WDBA-minimized automaton and the original
	automaton.
	* src/tgbatest/wdba.test: New test.
	* src/tgbatest/safety.test: Adjust comment.
	* src/tgbatest/spotlbtt.test: Use -Rm.
	* src/tgbatest/Makefile.am (TESTS): Add wdba.test.

259
260
261
262
263
264
265
266
267
268
269
270
2010-04-13  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Better resource handling in minimization.

	* src/tgbatest/ltl2tgba.cc (main): Delete the minimized automaton.
	* src/tgbaalgos/minimize.cc (minimize): Remove the call to
	unregister_variable() at the end.  It was both
	wrong (unregistering only the first variable) and useless ("delete
	del_a" will unregister all these variables).  Use a map and a set
	to keep track of free BDD variable and reuse them, otherwise the
	algorithm would sometimes use more variables than allocated.

271
272
273
274
275
276
277
278
279
280
281
282
2010-03-20  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Implement is_safety_automaton().

	* src/tgbaalgos/safety.hh, src/tgbaalgos/safety.cc: New
	files.
	* src/tgbaalgos/Makefile.am: Add them.
	* src/tgbatests/ltl2tgba.cc: Add option "-O".
	* src/tgbaalgos/scc.hh: Update documentation.
	* src/tgbatest/Makefile.am (TESTS): Add safety.test.
	* src/tgbatest/safety.test: New file.

283
284
285
286
2010-03-26  Felix Abecassis  <abecassis@lrde.epita.fr>

	* src/tgbaalgos/minimize.cc: Now use register_anonymous_variables.

Felix Abecassis's avatar
Felix Abecassis committed
287
288
289
290
291
292
293
294
295
296
2010-03-20  Felix Abecassis  <abecassis@lrde.epita.fr>

	Small fixes.

	* src/tgbatest/minimize.cc: Delete useless includes.
	* src/tgbaalgos/minimize.cc: Delete useless includes,
	fixed acceptance conditions.
	* src/tgbatest/ltl2tgba.cc: Add -Rm option for minimization.
	* src/tgba/tgbaexplicit.cc: Fixed typo.

297
298
2010-03-20  Felix Abecassis  <abecassis@lrde.epita.fr>

299
300
301
302
303
304
305
	Test program for the minimization algorithm.

	* src/tgbatest/minimize.cc: New file.  Minimize an automaton
	from a LTL formula and compare the size of the initial automaton
	to the size of the minimized automaton.

2010-03-20  Felix Abecassis  <abecassis@lrde.epita.fr>
306
307

	* src/tgbaalgos/minimize.cc, src/tgbaalgos/minimize.hh:
308
	New files.  Algorithm to minimize an automaton using first the powerset
309
310
311
312
	construction to determinize the input automaton, the automaton is then
	minimized using the standard algorithm, using BDDs to check if states
	are equivalent.

313
314
315
316
317
318
2010-03-20  Felix Abecassis  <abecassis@lrde.epita.fr>

	Modify the powerset algorithm to keep track of accepting states
	from the initial automaton.

	* src/tgba/tgbaexplicit.cc, src/tgba/tgbaexplicit.hh:
319
320
	Added class tgba_explicit_number, a tgba_explicit where states are
	labelled by integers.
321
322
323
324
325
	* src/tgbaalgos/powerset.hh, src/tgbaalgos/powerset.cc:
	When building the deterministic automaton, keep track of which states
	were created from an accepting state in the initial automaton.
	The states are added to the new optional parameter (if not 0),
	acc_list.
326
	Use tgba_explicit_number instead of tgba_explicit_string to build
327
328
329
330
	the result.
	* src/tgbaalgos/scc.cc (spot): Small fix.
	Print everything on std::cout.

331
332
333
334
335
336
337
338
339
340
341
342
343
2011-01-05  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix computation of support_conditions for bdd-based TGBA.
	This fixes a bug in the powerset of such TGBA on the minimize branch.

	* src/tgba/tgbabddconcrete.cc (compute_support_conditions): Also
	account for the conditions from the acceptance relations.
	* rc/tgba/tgbabddconcretefactory.hh, rc/tgba/tgbabddconcretefactory.cc
	(acceptance_conditions_support): New variable to hold the value
	of bdd_support(acceptance_conditions_support).
	* src/tgba/tgbabddconcretefactory.cc (finish): Update
	data_.acceptance_conditions_support.

344
345
346
347
2010-12-26  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* wrap/python/cgi-bin/ltl2tgba.in: Remove all "new" markers.

348
349
350
351
352
353
2010-12-23  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Define SWIG_TYPE_TABLE as suggested by the SWIG documentation.

	* wrap/python/Makefile.am: Add -DSWIG_TYPE_TABLE=spot.

354
355
356
357
358
359
360
2010-12-23  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Use swig2.0 if available.

	* configure.ac: Search for swig2.0 and swig.
	* wrap/python/Makefile.am: Use $(SWIG).

Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
2010-12-23  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Get rid of ltihooks.py.

	ltihooks.py apparently breaks the import mechanisms of Python 2.6,
	causes SWIG's runtime to fail to share a global type table, and
	yields various failures in our tests.

	* wrap/python/ltihooks.py: Delete.
	* wrap/python/Makefile.am (EXTRA_DIST): remove ltihooks.py.
	* wrap/python/tests/bddnqueen.py, wrap/python/tests/interdep.py,
	wrap/python/tests/ltl2tgba.py, wrap/python/tests/ltlparse.py,
	wrap/python/tests/ltlsimple.py, wrap/python/tests/minato.py,
	wrap/python/tests/modgray.py, wrap/python/tests/optionmap.py,
	wrap/python/tests/setxor.py: Do not use ltihooks.
	* wrap/python/tests/run.in (pypath): Include the .libs/ directories
	in the search path so that Python can find the *.so libraries.
	* wrap/python/cgi-bin/ltl2tgba.in: Insert the .libs/ directories
	into sys.path instead of importing ltihooks.

381
382
383
384
2010-12-12  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* NEWS: Summarize recent changes.

385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
2010-12-11  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Merge transitions in tgba_tba_proxy.

	With this change the output of
	ltl2tgba -f -x -k -DS "GF(p_1) & ... & GF(p_n)
	uses less than (n+1)^2 transitions when it used
	exactly (n+1)*(2^n) transitions before.

	* src/tgba/tgbatba.cc (tgba_tba_proxy_succ_iterator): Merge
	transitions going to the same states if they are both accepting or
	if neither are.
	(state_ptr_bool_t, state_ptr_bool_less_than): Helper type to
	store a transition in tgba_tba_proxy_succ_iterator.
	* src/tgba/tgbatba.cc, src/tgba/tgbatba.hh
	(tgba_tba_proxy::transition_annotation): Remove.  We cannot
	implement this method if transitions are merged.
	* src/tgbatest/ltl2tgba.test: Add a test.

404
405
406
407
408
409
410
2010-12-10  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Augment the size of the ltlclasses benchmark.

	* bench/ltlclasses/run: Augment the max size to 20.
	* bench/ltlcounter/run: Typo in comment.

411
412
413
414
415
416
417
418
419
2010-12-10  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Introduce -ks to print only the size of the automaton (without
	SCC information).

	* src/tgbatest/ltl2tgba.cc (syntax, main): Add a -ks option.
	* src/tgbatest/ltl2tgba.test, bench/ltlclasses/run,
	bench/ltlcounter/run: Use -ks instead of -k to speed things up.

420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
2010-12-09  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Use a cache to speed up tgba_tba_proxy.

	tgba_tba_proxy used to spend a lot of time (re)computing the
	acceptance condition common to all outgoing transition of a state.

	* src/tgba/tgbatba.hh (accmap_): New cache.
	(common_acceptance_conditions_of_original_state): New method.
	* src/tgba/tgbatba.cc (tgba_tba_proxy_succ_iterator::~sync)
	Call common_acceptance_conditions_of_original_state() instead of
	computing the result.
	(~tgba_tba_proxy): Cleanup the cache.
	(common_acceptance_conditions_of_original_state): Implement it.

435
436
437
438
2010-12-07  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/ltltest/Makefile.am (genltl_SOURCES): Add missing variable.

439
440
441
442
2010-12-07  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* README: Mention bench/ltlclases/.

443
444
445
446
447
448
449
450
2010-12-04  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Preliminary benchmark using genltl, introduced earlier.

	* bench/ltlclasses/: New benchmark.
	* bench/Makefile.am: Add it.
	* configure.ac: Adjust.

451
452
453
454
2010-12-04  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/ltlvisit/syntimpl.cc: Reduce the number of dynamic_cast<>s.

455
456
457
458
459
460
461
462
463
2010-12-04  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Preliminary implementation of a tool to generate some interesting
	families of LTL formulae.

	* src/ltltest/genltl.cc: New file.  Based on five classes of
	formulae defined in a paper by Cichón, Czubak, and Jasiński.
	* src/ltltest/Makefile.am (noinst_PROGRAMS): Build genltl.

464
465
466
467
468
469
470
471
472
473
474
2010-12-03  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Add full_parent support to to_spin_string().

	* src/ltlvisit/tostrinc.hh (to_spin_string): Add a full_parent
	optional parameter, like for the to_string() function.
	* src/ltlvisit/tostrinc.cc (to_string_visitor): Fix the
	handling of full_parent.
	(to_spin_string_visitor): Handle full_parent.

2010-12-01  Alexandre Duret-Lutz  <adl@lrde.epita.fr>
475
476
477
478

	Halve the number of application of eventual_universal_visitor in
	reduce_visitor::visit(binop).

479
	* src/ltlvisit/reduce.cc (eventual_universal_visitor::recurse_):
480
481
482
483
484
485
486
	Move this method...
	(recurse_eu): ... outside as a separate function.  Likewise for
	the universal/eventual result struct.
	(reduce_visitor::visit(binop)): Call recurse_eu() once to replace
	two calls to is_eventual and is_universal, thus replacing two
	recursions by one.

487
488
489
490
491
492
493
494
495
2010-12-01  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Move the eventual-universal functions where the belong.

	* src/ltlvisit/syntimpl.cc (eventual_universal_visitor,
	is_eventual, is_universal): Move ...
	* src/ltlvisit/reduce.cc (eventual_universal_visitor,
	is_eventual, is_universal): ... here.

496
497
498
499
2010-11-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/ltlvisit/randomltl.cc (random_ltl::update_sums): Typo in string.

500
501
502
503
504
505
506
507
508
509
510
511
512
2010-11-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Remove a quadratic behavior in eventual_universal_visitor.

	* src/ltlvisit/syntimpl.cc (eventual_universal_visitor): Use
	a union to store the eventual and universal properties as two
	bit in a bit-field, and "AND" both of them at once.
	(eventual_universal_visitor::recurse_un,
	eventual_universal_visitor::recurse_ev): Replace these
	two functions by ...
	(eventual_universal_visitor::recurse_): ... this one, that
	returns both bits as an unsigned.

513
514
515
516
517
2010-12-01  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbatest/ltl2tgba.cc (main): Delete the accepting run
	even if it hasn't been printed.

518
519
520
521
522
523
524
525
526
2010-11-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Rationalize options for counter-example output.

	* src/tgbatest/ltl2tgba.cc (main): Either replay the accepting
	run or print it, but do not do both.
	* src/tgbatest/emptchk.test: Adjust. I.e. use -C instead of -CR
	when we expect the run to be displayed.

Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
527
528
529
530
531
532
533
534
2010-11-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix a GCC 4.6 warning.

	* src/tgbatest/randtgba.cc (main): Remove the set but unused opt_A
	variable (the upcoming GCC 4.6 would warn about it) and set opt_ec
	to 1 if -A is used without -e.

535
536
537
538
2010-11-27  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbatest/ltl2tgba.cc (syntax): Typo.

Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
539
540
541
542
543
544
545
2010-11-27  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Another Clang report.

	* iface/nips/nips.cc (format_state): Do not use a variable-sized
	array, this is not allowed in C++.

546
547
548
549
550
551
552
553
554
2010-11-27  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix more errors reported by Clang.

	* src/tgbaalgos/reducerun.hh (tgba_run): Predeclare as a struct
	since this is what it is.
	* src/tgbatest/randtgba.cc (main): Avoid using "i" with two
	different type in the same loop.

555
556
557
558
559
560
561
562
563
2010-11-26  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Finalize Kripke interface.

	* src/kripke/fairkripke.hh, src/kripke/fairkripke.cc,
	* src/kripke/kripke.hh, src/kripke/kripke.cc: Finalize and
	document the Kripke interface.  I have tested it by updating
	checkpn to use it.

564
565
566
567
568
569
570
571
572
573
574
2010-11-25  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Never claim output used to print the degeneralized automaton
	before some optional operations (like more optimizations, or a
	product).

	* src/tgbatest/ltl2tgba.cc (-N, -NN): Make sure we print the last
	automaton computed, not just the automaton when we degeneralized
	it.  We may have applied other algorithms since the original
	degeneralization.

575
576
577
578
579
580
2010-11-25  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbatest/ltl2tgba.test: Test both -l and -f.  This should
	have been done on 2010-01-30 when the default translation was
	changed from -l to -f.

581
582
583
584
2010-11-25  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbaalgos/scc.hh: Typos in the documentation.

585
586
587
588
2010-11-24  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbaalgos/sccfilter.hh: Fix some typos in the documentation.

589
590
591
592
593
594
595
2010-11-24  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Suggest using bddtrue and bddfalse instead of bdd_true() and
	bdd_false().

	* src/sanity/style.test: Catch uses of bdd_true() or bdd_false().

596
597
598
599
600
601
602
603
604
2010-11-20  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix some struct/class missmatches reported by clang.

	* src/ltlast/predecl.hh: Predeclare the LTL AST nodes as class,
	not struct.
	* src/ltlast/nfa.hh (formula_tree::node): Predeclare as struct,
	not class.

605
606
607
608
609
610
611
612
2010-11-07  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Add interface for and test the bdd_setxor() function added to Buddy.

	* wrap/python/buddy.i (bdd_setxor): New function.
	* wrap/python/tests/setxor.py: New file.
	* wrap/python/tests/Makefile.am (TESTS): Add setxor.py.

613
614
615
616
2010-11-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/Makefile.am (libspot_la_LIBADD): Rename libneverclaimparse.la
	as libneverparse.la.
617
	* src/neverparse/Makefile.am: Install files in
618
619
	$(pkgincludedir)/neverparse, not $(pkgincludedir)/neverclaimparse.

620
621
622
623
624
625
626
627
628
2010-11-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Cosmetics to please sanity checks.

	* src/neverparse/public.hh, src/neverparse/parsedecl.hh: Fix
	inclusion guards.
	* src/tgba/tgbaexplicit.hh, src/tgbatest/emptchk.test,
	src/tgbatest/ltl2tgba.cc: Fix trailing whitespaces.

629
630
631
632
633
2010-11-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbatest/ltl2tgba.cc: Clock the time spent reading -P file.

2010-11-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>
634
635
636
637

	* src/tgbatest/neverclaimread.test: Check that Spot can read the
	neverclaims it outputs.

638
639
640
641
642
643
644
645
646
647
648
2010-11-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Do not output a counterexample by default in ltl2tgba, introduce
	options -C and -CR for that.

	* src/tgbatest/ltl2tgba.cc: Add option -C and -CR to control
	whether we want the accepting run to be printed or replayed.
	* src/tgbatest/dfs.test, src/tgbatest/eltl2tgba.test,
	src/tgbatest/emptchk.test, src/tgbatest/emptchke.test,
	src/tgbatest/ltl2tgba.cc, src/tgbatest/ltlcounter.test: Use -CR.

649
650
651
652
653
654
655
656
657
658
659
2010-11-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Make sure the neverclaim parser works on the output of spin and
	ltl2ba.

	* src/neverparse/neverclaimparse.yy: Accept multiple labels
	for the same state.  Honor accepting states.  Forward parse
	error from the parser used for guards.  Accept "false" as a
	single instruction for a state.
	* src/neverparse/neverclaimscan.ll: Recognize "false" specifically,
	and remove the ";" hack.
660
	* src/tgba/tgbaexplicit.cc
661
662
663
664
665
666
	(tgba_explicit_string::~tgba_explicit_string): Adjust not to
	destroy a state twice.
	* src/tgba/tgbaexplicit.hh
	(tgba_explicit_string::add_state_alias): New function.
	* src/tgbatest/defs.in (SPIN, LTL2BA): New variables.
	* src/tgbatest/neverclaimread.test: Check error messages for
667
	syntax errors in guards.  Make sure we can read the output
668
669
	of `spin -f' and `ltl2ba -f' on a few test formulae.

670
671
672
673
674
675
676
677
678
679
2010-11-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Cleanup neverclaim support.

	* src/neverclaimparse/: Shorthen as ...
	* src/neverparse/:... this.
	* src/Makefile.am: Adjust, and add back the directories mistakenly
	removed by previous patch.
	* README: Adjust, and keep the file's width under 80 columns.
	* configure.ac: Adjust.
680
681
682
	* src/neverparse/Makefile.am, src/neverparse/fmterror.cc,
	src/neverparse/neverclaimparse.yy,
	src/neverparse/neverclaimscan.ll, src/neverparse/public.hh:
683
684
685
686
687
688
689
	Fix copyright.
	* src/tgbatest/Makefile.am (check_PROGRAMS): Remove neverclaimread.
	* src/tgbatest/ltl2tgba.cc: Add option -XN to read a neverclaim.
	* src/tgbatest/readneverclaim.cc: Delete.
	* src/tgbatest/neverclaimread.test: Use ltl2tgba instead of
	neverclaimread.

Felix Abecassis's avatar
Felix Abecassis committed
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
2010-05-25  Felix Abecassis  <abecassis@lrde.epita.fr>

	Add never claim parser.

	* src/neverclaimparse/: New directory.
	* src/neverclaimparse/fmterror.cc: New file.  Print a formatted parse
	error on a output stream.
	* src/neverclaimparse/neverclaimparse.yy: New file.  Parser declaration
	for Bison.
	* src/neverclaimparse/neverclaimscan.ll: New file.  Scanner declaration
	for Flex.
	* src/neverclaimparse/public.hh: New file.  Public header for external
	use.
	* src/neverclaimparse/parsedecl.hh: New file.  Header file for
	Flex-Bison interaction.
	* src/neverclaimparse/Makefile.am: New Makefile.
	* src/tgbatest/neverclaimread.cc: New file.  Test program for the
	never claim parser.
	* src/tgbatest/neverclaimread.test: New file.  Test script for the
	never claim parser.
	* src/tgbatest/Makefile.am: Adjust.
	* configure.ac : Adjust.
	* README: Adjust.

714
715
716
717
718
719
720
721
722
723
2010-11-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Remove `readsave' and fix line numbers in tgbaparse error messages.

	* src/tgbaparse/tgbaparse.yy (line): Fix computation of line number
	for error messages when parsing conditions.
	* src/tgbatest/readsave.test: Check the syntax position of syntax errors
	in the diagnostics.  Use ltl2tgba instead of readsave.
	* src/tgbatest/Makefile.am (check_PROGRAMS): Remove readsave.

724
725
726
727
2010-11-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* bench/emptchk/pml2tgba.pl: Adjust to work with Spin 5.2.5.

728
729
730
731
2010-10-07  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* configure.ac: Do not run CF_GXX_WARNINGS unless they are enabled.

732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
2010-10-07  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Hide the safra_tree_automaton type from the public interface.

	We do that because the declaration of this type, which is local to
	src/tgba/tgbasafracomplement.cc has a member in an anonymous
	namespace, and some versions of g++-4.2 issue a very annoying
	warning about this legitimate code.  See Bug 29365 on GCC's
	Bugzilla.  Report by Silien Hong <silien.hong@lip6.fr>.

	* src/tgba/tgbasafracomplement.hh (safra_tree_automaton): Do not
	forward declare.
	(tgba_safra_complement): Use void* instead of
	safra_tree_automaton*.
	* src/tgba/tgbasafracomplement.cc: static_cast void* to
	safra_tree_automaton* anywhere needed.

749
750
751
752
753
754
755
2010-05-20  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix the --enable-optimizations check.

	* m4/gccoptim.m4: Add missing AC_LANG_PUSH/AC_LANG_POP around the
	C test.  It was using the C++ compiler instead...

Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
756
757
758
759
2010-04-16  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* NEWS: Typo.

760
761
762
763
2010-04-16  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* NEWS, configure.ac: Bump version to 0.6a.

Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
764
765
766
767
768
769
2010-04-16  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Release Spot 0.6.

	* NEWS, configure.ac: Bump version to 0.6.

770
771
772
773
774
775
776
777
2010-04-15  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Reorder recent additions to reduccmp.test.

	* src/ltltest/reduccmp.test: Reorder the test added by the
	previous patches.  Some are not supposed to be reduced by
	reductaustr.

778
779
780
781
782
783
784
785
786
2010-04-15  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix a long-standing bug in the stronger rule for R and its recent
	clone for M.

	* src/ltlvisit/contain.cc (reduce_tau03_visitor): Remove
	the stronger rules for R and M.  They were wrong.
	* src/ltltest/reduccmp.test: Test a simpple counterexample.

787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
2010-04-15  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	More simplifications rules for M.

	* src/ltlvisit/reduce.cc (reduce_visitor): Add the following
	implication rewriting rules:
	a M (b M c) = a M c if a implies b.
	a M (b R c) = a M c if a implies b.
	a R (b R c) = a R c if a implies b.
	a R (b M c) = b M c if b implies a.
	a M (b M c) = b M c if b implies a.
	The latter rule was fixed from an incorrectly copied&pasted
	rule for a M (b R c) = b R c if b implies a (this is wrong).
	Also remove the wrong rule for a W (b U c) = b U c if a implies b.
	* src/ltltest/reduccmp.test: Add more tests.

803
804
805
806
807
808
809
2010-04-15  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Speed up syntactic_implication() for constants.

	* src/ltlvisit/syntimpl.cc (syntactic_implication): Do not
	create visitors if arguments are constant.

810
811
812
813
814
815
816
2010-04-15  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix simplification of "a M true" as Fa.

	* src/ltlvisit/simpfg.cc: Typo.
	* src/ltltest/reduccmp.test: Add more tests.

817
818
819
820
2010-04-15  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* HACKING: Bison 2.4.2 has a bugfix we rely on.

821
822
823
824
825
2010-04-15  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbatest/ltl2tgba.cc (syntax): Add missing black line in
	help output.

826
827
828
829
2010-04-14  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* NEWS: Mention W and M.

830
831
832
833
834
835
836
837
838
839
840
2010-04-14  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	More LTL reductions for W and M.

	* src/ltlvisit/basicreduce.cc: Perform the following reductions:
	(a R b) | Gb = a R b
	(a M b) | Gb = a R b
	(a U b) & Fb = a U b
	(a W b) & Fb = a U b
	* src/ltltest/reduccmp.test: Test them.

841
842
843
844
2010-04-12  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* wrap/python/cgi-bin/ltl2tgba.in: Document W and M operators.

845
846
847
848
849
850
851
852
853
854
855
2010-04-12  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	More LTL reductions for W and M.

	* src/ltlvisit/basicreduce.cc: Perform the following reductions:
	(a U b) & (c W b) = (a & c) U b
	(a W b) & (c W b) = (a & c) W b
	(a R b) | (c M b) = (a | c) R b
	(a M b) | (c M b) = (a | c) M b
	* src/ltltest/reduccmp.test: Test them.

856
857
858
859
860
861
862
863
864
865
866
867
868
869
2010-04-12  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Add LTL reductions for strong release.

	* src/ltlvisit/basicreduce.cc: Perform the following reductions.
	a R (b & F(a)) = a M b
	a M (b & F(a)) = a M b
	a R Fa = Fa
	a M Fa = Fa
	a R b & Fa = a M b
	a R b & a M c = a M (b & c)
	a M b & a M c = a M (b & c)
	* src/ltltest/reduccmp.test: More tests.

870
871
872
873
874
875
876
877
878
879
880
881
882
883
2010-04-12  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Add LTL reductions for weak until.

	* src/ltlvisit/basicreduce.cc: Perform the following reductions.
	a U (b | Ga) = a W b
	a W (b | Ga) = a W b
	a U b | Ga = a W b
	a U b | a W c = a W (b | c)
	a W b | a W c = a W (b | c)
	a U Ga = Ga
	a W Ga = Ga
	* src/ltltest/reduccmp.test: More tests.

884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
2010-04-07  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Add support for W (weak until) and M (strong release) operators.

	* src/ltlast/binop.cc, src/ltlast/binop.cc: Add support for
	these new operators.
	* src/ltlparse/ltlparse.yy, src/ltlparse/ltlscan.ll: Parse them.
	* src/ltltest/reduccmp.test: Add new tests for W and M.
	* src/ltlvisit/basicreduce.cc, src/ltlvisit/contain.cc,
	src/ltlvisit/lunabbrev.cc, src/ltlvisit/nenoform.cc,
	src/ltlvisit/randomltl.cc, src/ltlvisit/randomltl.hh,
	src/ltlvisit/reduce.cc, src/ltlvisite/simpfg.cc,
	src/ltlvisit/simpfg.hh, src/ltlvisit/syntimpl.cc,
	src/ltlvisit/tostring.cc, src/tgba/formula2bdd.cc,
	src/tgbaalgos/eltl2tgba_lacim.cc, src/tgbaalgos/ltl2taa.cc,
	src/tgbaalgos/ltl2tgba_fm.cc, src/tgbaalgos/ltl2tgba_lacim.cc:
	Add support for W and M.
	* src/tgbatest/ltl2neverclaim.test: Test never claim output
	using LBTT, this is more thorough.  Also we cannot use -N
	any more in the spotlbtt.test.
	* src/tgbatests/ltl2tgba.cc: Define M and W for ELTL.
	* src/tgbatest/ltl2neverclaim.test: Test W and M, and use
	-DS instead of -N, because lbtt-translate does not want
	to translate these operators for tools that masquerade as Spin.

909
910
911
912
913
914
915
916
917
918
2010-04-12  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Adjust ltl2tgba.py to call scc_filter() with the "full" option as
	appropriate.

	* wrap/python/spot.i (spot::scc_filter): Make it available.
	* wrap/python/cgi-bin/ltl2tgba.in (reduce_scc): Call scc_filter.
	Use the "full" option unless the show_degen_png or
	show_never_claim are set.  Also reduce_scc the default.

919
920
921
922
2010-04-08  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/ltlvisit/basicreduce.cc: Typo in comment.

923
924
925
926
2010-04-08  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* NEWS: Summarize recent noteworthy changes.

927
928
929
930
931
932
933
934
935
936
2010-04-07  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Modernize Bison parsers.

	* src/ltlparse/ltlparse.yy, src/tgbaparse/tgbaparse.yy,
	src/evtgbaparse/evtgbaparse.yy, src/eltlparse/eltlparse.yy: Use
	token types for %destructor and %printer.  Remove the yylex hack,
	since %name-prefix is now honored by Bison.  Also remove the
	useless <token> type.  Suggested by Akim Demaille.

937
938
939
940
941
942
943
944
945
2010-03-10  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix column in LTL error messages, it was off by one.

	* src/ltlparse/fmterror.cc (format_parse_errors): Count columns
	starting at 1.  Older Bison used to start at 0 but changed to
	match the GNU Coding Standards.
	* src/ltltest/parseerr.test: Add a test case.

946
947
948
949
950
951
952
953
2010-03-07  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Do not rewrite F(a & GF(b)) = F(a) & GF(b), this can be harmful.

	* src/ltlvisit/basicreduce.cc (basic_reduce_visitor::recurse):
	Disable this rule unconditionally.
	* src/ltltest/reduccmp.test: Adjust tests.

954
955
956
957
2010-03-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgba/tgbatba.cc: Fix English in comments.

958
959
960
961
962
963
964
965
966
967
968
2010-03-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Reverse the order of expected acceptance conditions in
	degeneralization.

	* src/tgba/tgbatba.cc (tgba_sba_proxy::tgba_tba_proxy): Build the
	list of acceptance condition in the reverse order.  The order is
	still arbitrary, but the bdd_satone() call seems to output the
	acceptance conditions that are more used first, and this helps the
	degeneralization process.

969
970
971
972
973
974
975
976
977
2010-03-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Tweak precedence of "->" and <->.

	* src/ltlparse/ltlparse.yy: Change the precedence of "->" and
	"<->" so that "a & b -> c" is interpreted as "(a & b) -> c"
	instead of "a & (b -> c)".  The new interpretation is more
	intuitive, and matches that of LBTT.

978
979
980
981
982
2010-03-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* bench/ltl2tgba/formulae.ltl: Fix three formulae to match the
	original paper by Somenzi and Bloem.  Reported by Ruediger Ehlers.

983
984
985
986
987
988
989
2010-03-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix memory leak introduced in yesterday's change.

	* src/tgba/tgbatba.cc (tgba_sba_proxy::tgba_sba_proxy): Do not
	forget to free the initial state after usage.

990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
2010-03-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Keep acceptance conditions on transitions going to accepting SCCs
	by default in scc_filter().

	Doing so helps the degeneralization algorithm, because it will
	have more opportunity to be in an accepting level when it reaches
	the accepting SCCs.

	* src/tgbaalgos/sccfilter.cc (filter_iter::filter_iter): Take a
	remove_all_useless argument.
	(filter_iter::process_link): Use the flag to decide whether to
	filter acceptance conditions going to accepting SCCs.
	(scc_filter): Take a remove_all_useless argument and pass it to
	filter_iter.
	* src/tgbaalgos/sccfilter.hh (filter_iter): Add the new argument
	and document the function.
	* src/tgbatest/tgbatests/ltl2tgba.cc (main): Add option use -R3
	for remove_all_useless=false and add -R3f for
	remove_all_useless=true.
	* src/tgbatest/ltl2tgba.test: Show one case where -R3f makes
	the degeneralization worse than -R3.

1013
1014
1015
1016
1017
2010-03-05  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Simplify F(a)|F(b) as F(a|b).  Add similar rule for G(a)&G(b).

	* src/ltlvisit/basicreduce.cc (basic_reduce_visitor): Replace
1018
	the FG(a)|FG(b) == F(Ga|Gb) rule by the above more generic one.
1019
1020
1021
1022
	Add the dual rule for G(a)&G(b), as we had none (this one won't
	improve anything in the translation, but it is more symmetric
	this way).  Also simplify some pointer checks.

1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
2010-03-05  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Better selection of the acceptance of the initial state in SBA.

	* src/tgba/tgbatba.cc (tgba_sba_proxy::tgba_sba_proxy): Set
	cycle_start_ to start in the accepting layer of the degeneralized
	automaton if the initial state has an accepting self-loop.
	Otherwise, starts at the level of the first acceptance condition
	as previously.
	(tgba_sba_proxy::get_init_state): Use cycle_start_.
	* src/tgba/tgbatba.hh (tgba_tba_proxy::a_): Make it protected so
	that we can use it in tgba_sba_proxy::tgba_sba_proxy.
	(tgba_sba_proxy::cycle_start_, tgba_sba_proxy::get_init_state):
	Declare.
	* src/tgbatest/ltl2tgba.test: More tests.

1039
1040
1041
1042
1043
1044
1045
1046
1047
2010-03-05  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Generalize the previous patch to accepting states in SBA.

	* src/tgba/tgbatba.cc (tgba_tba_proxy_succ_iterator::sync_): Move
	the optimization step added by the previous patch outside the
	before the bddtrue check, so that it also applies to accepting
	states in SBA.

1048
1049
1050
1051
1052
2010-03-03  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Optimize tgba_tba_proxy and tgba_sba_proxy for states that share
	an acceptance condition on all outgoing transitions.

1053
	This was motivated by experiments from Rüdiger Ehlers, showing
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
	that "ltl2ba -f 'a U (b U c)'" outperformed "ltl2tgba -f -N -R3 'a
	U (b U c)'".  With this change and the previous one, it is no
	longer the case.

	* src/tgba/tgbatba.cc (tgba_tba_proxy_succ_iterator::aut_): Store
	a pointer to the source automaton and...
	(tgba_tba_proxy_succ_iterator::sync_): ... use it in an extra
	optimization step to gather the acceptance conditions common
	to all outgoing transitions of the destination state, and pretend
	they are on the current (ingoing) transition.
	(tgba_tba_proxy::succ_iter): Pass the
	source automaton to the constructed iterator.
	* src/tgbatest/spotlbtt.test: Test -f -N -R3 -r7.
	* src/tgbatest/ltl2tgba.test: Add a test case for 'a U (b U c)'.

1069
1070
1071
1072
1073
1074
1075
2010-03-03  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	ltl2tgba: apply -R3 before -D or -DS.

	* src/tgbatest/ltl2tgba.cc (main): Call scc_filter() before the
	degeneralization, because it might remove useless acceptance
	conditions.  I realized this while looking at experiments from
1076
	Rüdiger Ehlers.
1077

1078
1079
1080
1081
2010-02-24  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/sanity/style.test: Better fix for the previous error.

1082
1083
1084
1085
2010-02-23  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Work around a spurious style.test error.

1086
	* src/saba/sabacomplementtgba.hh (spot): Rewrite Büchi as B\"uchi
1087
1088
1089
1090
	is the BibTex entry used as comment, because some version of sed
	will choke on non-ascii character and cause sanity/style.test to
	fail.

1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
2010-02-23  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix random_graph() not to generate dead states.

	This is actually the third time I fix random_graph().  On
	2007-02-06 I changed the function not to generated dead states,
	but in a way that made it non-deterministic.  On 2010-01-20 I made
	the function deterministic again, but it started to generate dead
	states as a side effect.  This time, I'm making sure that dead
	states won't come again with a test-case that we should have had
	from the beginning.

	* src/tgbaalgos/randomgraph.cc (random_graph): Add an extra
	indirection array, state_randomizer[], so that we can reorder
	states indices after a random selection without actually changing
	the value of the indices used by unreachable_states and
	nodes_to_process.
	* src/tgbatest/randtgba.test: New file.
	* src/tgbatest/Makefile.am: Add randtgba.test.

Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
2010-02-17  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	ltl2tgba cgi updates.

	* wrap/python/cgi-bin/ltl2tgba.in (dot): Use the value computed by
	configure.
	(os.system): Cleanup stale files only when the form has been
	submitted.
	(list options): Keep track of the selected value.
	(draw_acc_run|print_acc_run): set ec=0 to detect if it has been
	later set or not.  Fix error message when using generalized
	automata with degeneralized emptiness checks.
	* wrap/python/cgi-bin/Makefile.am (ltl2tgba.py): Substitute @DOT@.

1125
1126
1127
1128
2010-02-02  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* wrap/python/cgi-bin/ltl2tgba.in: Reword description of svg_output.

1129
1130
1131
1132
1133
1134
1135
1136
2010-02-02  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Add SVG output and language containment options to the cgi script.

	* wrap/python/cgi-bin/ltl2tgba.in (new): Mark new options as new.
	(svg_output, reduce_langcout): Add these new options.
	(render_dot): Support svg_output.

Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
1137
1138
1139
1140
2010-02-02  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* NEWS: Typo.

1141
1142
1143
1144
2010-02-01  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* NEWS, configure.ac: Bump version to 0.5a.

Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
1145
1146
1147
1148
1149
1150
2010-02-01  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Release Spot 0.5.

	* NEWS, configure.in: Bump version to 0.5.

1151
1152
1153
1154
1155
1156
2010-01-31  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* doc/Makefile.am ($(srcdir)/stamp): Do not depend on dot
	explicitly, otherwise the documentation is always built and
	distcheck fails.

Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
1157
1158
1159
1160
1161
1162
1163
1164
1165
2010-01-31  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	More Doxygen fixes.

	* src/sabaalgos/sabareachiter.hh (process_link): Document argument SI.
	* src/eltlparse/public.hh (format_parse_errors): Remove the
	non-existing eltl_string argument from the description.
	(parse_file): Fix name of parameters in documentation.

1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
2010-01-31  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Build doxygen pictures with libgd to reduce their size.

	Doxygen only knows how to call dot with -Tpng, while using
	-Tpng:gd produces pictures that are 10 times smaller.  Use a
	simple wrapper around dot to simplify this.

	* doc/dot.in: New file, that wrap the system's dot and replace
	-Tpng by -Tpng:gd.
	* doc/Makefile.am ($(srcdir)/stamp): Depend on dot.
	* doc/Doxyfile.in: Update to 1.6.2.
	(DOT_PATH): Set to @srcdir@ to use doc/dot instead of the
	system's dot.
	* configure.ac: Find the absolute path of dot, and generate
	the doc/dot script.

Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
1183
1184
1185
1186
1187
1188
1189
1190
2010-01-31  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	More Doxygen fixes.

	* src/tgba/tgbakvcomplement.hh: Use \verbatim around the bibtex
	entry.
	* src/saba/sabacomplementtgba.hh: Use latin1.

1191
1192
1193
1194
1195
2010-01-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* bench/split-product/Makefile.am (nodist_noinst_DATA): Do not
	depend on files that cannot be built.

1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
2010-01-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Replace spot::ltl_file by a rewritten spot::ltl::ltl_file.

	* src/tgba/tgbafromfile.cc, src/tgba/tgbafromfile.hh: Delete these
	files.
	* src/tgba/Makefile.am: Remove them.
	* src/ltl/ltlparse/ltlfile.hh, src/ltl/ltlparse/ltlfile.cc: New
	files.
	* src/ltl/ltlparse/Makefile.am: Add them.
	* bench/scc-stats/stats.cc, bench/split-product/cutscc.cc: Rewrite
	using the new class.

1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
2010-01-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Check for missing Copyright blurbs, and add them.

	* src/sanity/style.test: Check for missing Copyrights blurbs.
	* src/sanity/Makefile.am: Run style.test before includes.test.
	* iface/gspn/dcswave.test, iface/gspn/dcswaveeltl.test,
	iface/gspn/dcswavefm.test, iface/gspn/dcswaveltl.test,
	iface/gspn/simple.test, iface/gspn/udcsefm.test,
	iface/gspn/udcseltl.test, iface/gspn/udcsfm.test,
	iface/gspn/udcsltl.test, iface/nips/nipstest/dotty.test,
	iface/nips/nipstest/emptiness.test, src/eltltest/acc.test,
	src/eltltest/nfa.test, src/saba/sabacomplementtgba.cc,
	src/sabatest/sabacomplementtgba.cc, src/tgbatest/eltl2tgba.test,
	src/tgbatest/taatgba.test: Add missing Copyright blurb.

Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
1225
1226
1227
1228
2010-01-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* NEWS: More text.

1229
1230
1231
1232
1233
1234
1235
1236
1237
2010-01-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Touch up some doxygen comments and copyrights.

	* eltlparse/public.hh, saba/saba.hh, tgba/tgbakvcomplement.hh,
	tgba/tgbasafracomplement.hh, tgbaalgos/eltl2tgba_lacim.cc,
	tgbaalgos/eltl2tgba_lacim.hh, tgbaalgos/ltl2taa.hh: Comment
	changes.

1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
2010-01-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Add SCC pruning options to the CGI script.

	* wrap/python/cgi-bin/ltl2tgba.in: Add options to symbolically
	prune unaccepting SCCs in LaCIM, and explicitely pruns unaccepting
	SCCs in all algorithms.
	* src/tgbaalgos/reductgba_sim.hh: Conceal most of the file to
	SWIG.
	* wrap/python/spot.i: Include reductgba_sim.hh.

1249
1250
1251
1252
2010-01-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/evtgbatest/ltl2evtgba.test: Replace * by &.

1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
2010-01-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Make it possible to use the cgi script without installing a web
	server.

	* wrap/python/cgi-bin/ltl2tgba.in: Starts a web server if the
	script is not called as a CGI.  Arrange to load libraries from
	the build directory.  Create the spotimg/ if needed when run as
	a web server.
	* wrap/python/cgi-bin/Makefile.am: Adjust build rule and clean
	the spotimg directory.
	* wrap/python/cgi-bin/README, NEWS: Update.

1266
1267
1268
1269
1270
1271
2010-01-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	More * -> & replacements.

	* src/ltltest/parse.test, src/ltltest/syntimpl.test: Replace * by &.

1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
2010-01-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Remove the theoretically bogus "containment" option of ltl2tgba_fm.

	* src/tgbaalgos/ltl2tgba_fm.cc, src/tgbaalgos/ltl2tgba_fm.hh:
	Remove the containment option.
	* src/tgbafromfile.cc, src/tgbafromfile.hh: Remove the
	containment_ member.
	* src/tgbatest/ltl2tgba.cc (syntax): Remove -c option for
	FM algorithm, use it exclusively for TAA.

1283
1284
1285
1286
1287
2010-01-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgba/tgbasafracomplement.hh: Add missing copyright and
	fix some comments.

1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
2010-01-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Rename tgba_complement as tgba_kv_complement.

	* src/tgba/tgbacomplement.hh, src/tgba/tgbacomplement.cc: Rename
	as...
	* src/tgba/tgbakvcomplement.hh, src/tgba/tgbakvcomplement.cc:
	... these. It makes more sense since we also have
	tgba_safra_complement.
	* src/tgba/Makefile.am, src/tgbatest/complement.cc, NEWS: Adjust.

1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
2010-01-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Do not recognize "*" as "and".  This leaves room for an
	implementation of rational operators in a future version.

	* src/ltlparse/ltlscan.ll: Do not recognize "*".
	* wrap/python/cgi-bin/ltl2tgba.in: Undocument it.
	* NEWS: Mention this.
	* src/tgbatest/kv.test, src/tgbatest/ltl2tgba.test,
	src/tgbatest/reductgba.test: Replace "*" by "&".

1310
1311
1312
1313
1314
1315
1316
1317
2010-01-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Make Couvreur/FM the default translation.

	* src/tgbatest/ltl2tgba.cc (syntax, main): Do it.
	* NEWS: Mention it.
	* src/tgbatest/emptchk.test: Add missing -l.

1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
2010-01-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Overhaul LaCIM's ELTL options.

	* src/tgbatest/ltl2tgba.cc (syntax, main): Introduce -le to select
	this algorithm and -lo to add the default LTL operators.  This
	replace the undocumented hack to add LTL operators when the
	formula with read for command-line, or the automaton was output
	for LBTT.
	* src/tgbatest/eltl2tgba.test, src/tgbatest/spotlbtt.test: Update
	call syntax.
	* NEWS: Mention -le, -lo, and -taa.

Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
2010-01-30  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Touch up -R3b handling.

	* src/tgbatest/ltl2tgba.cc (syntax): Move -R3b with the other
	LaCIM options.
	(main): Speak of "symbolic SCC pruning" instead of "deleting
	unaccepting SCC", and do that right after the translation, before
	degeneralization.  Also error out when -R3b is used on non
	symbolic automata.

1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
2010-01-29  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Update some text files for upcoming 0.5.

	* NEWS: Update for upcoming 0.5.
	* HACKING: Update Automake requirement.
	* README: Mention the mailing list.
	* bench/ltlcounter/README: More text.
	* configure.ac: Report bugs to spot@lrde.epita.fr.

1352
1353
1354
1355
1356
1357
1358
1359
2010-01-29  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Rename wrap/python/cgi/ as wrap/python/cgi-bin/.

	* wrap/python/cgi/: Rename as ...
	* wrap/python/cgi-bin/: ... this.
	* configure.ac, spot/wrap/python/Makefile.am, README: Adjust.

1360
1361
1362
1363
2010-01-29  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbaalgos/gtec/gtec.hh: Fix copyright.

1364
1365
1366
1367
1368
2010-01-29  Felix Abecassis <felix.abecassis@lrde.epita.fr>

	* src/tgba/taatgba.cc, src/tgba/taatbga.hh: Fix a memory issue on
	Darwin.

1369
1370
1371
1372
1373
2010-01-25  Damien Lefortier <dam@lrde.epita.fr>

	* wrap/python/cgi/ltl2tgba.in, wrap/python/spot.i: Add a new
	translation algorithm: Tauriainen/TAA.

1374
1375
1376
1377
1378
1379
2010-01-25  Damien Lefortier <dam@lrde.epita.fr>

	* wrap/python/cgi/ltl2tgba.in: Use the uuid Python module instead
	of the UNIQUE_ID environment variable to avoid being
	Apache-specific.

Guillaume Sadegh's avatar
Guillaume Sadegh committed
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
2010-01-24  Guillaume Sadegh  <sadegh@lrde.epita.fr>

	Fix copyrights.

	* bench/Makefile.am, bench/gspn-ssp/Makefile.am,
	bench/gspn-ssp/defs.in, bench/scc-stats/Makefile.am,
	bench/split-product/Makefile.am, configure.ac,
	iface/Makefile.am, iface/gspn/Makefile.am, iface/gspn/ssp.hh,
	iface/nips/Makefile.am, iface/nips/common.cc,
	iface/nips/common.hh, iface/nips/dottynips.cc,
	iface/nips/nips.cc, iface/nips/nips.hh, src/Makefile.am,
	src/eltlparse/Makefile.am, src/eltlparse/eltlparse.yy,
	src/eltlparse/eltlscan.ll, src/eltlparse/fmterror.cc,
	src/eltlparse/parsedecl.hh, src/eltltest/Makefile.am,
	src/eltltest/defs.in, src/eltltest/nfa.cc, src/evtgba/evtgba.hh,
	src/evtgba/product.cc, src/evtgba/product.hh,
	src/evtgbaalgos/tgba2evtgba.cc, src/evtgbaparse/Makefile.am,
	src/evtgbaparse/evtgbaparse.yy, src/evtgbatest/defs.in,
	src/evtgbatest/explicit.test, src/evtgbatest/ltl2evtgba.cc,
	src/evtgbatest/ltl2evtgba.test, src/evtgbatest/product.cc,
	src/evtgbatest/product.test, src/evtgbatest/readsave.cc,
	src/evtgbatest/readsave.test, src/ltlast/atomic_prop.cc,
	src/ltlast/atomic_prop.hh, src/ltlast/binop.cc,
	src/ltlast/binop.hh, src/ltlast/constant.cc,
	src/ltlast/constant.hh, src/ltlast/formula.cc,
	src/ltlast/formula.hh, src/ltlast/formula_tree.cc,
	src/ltlast/formula_tree.hh, src/ltlast/multop.cc,
	src/ltlast/multop.hh, src/ltlast/nfa.cc, src/ltlast/nfa.hh,
	src/ltlast/unop.cc, src/ltlast/unop.hh, src/ltlenv/declenv.cc,
	src/ltlenv/declenv.hh, src/ltlenv/environment.hh,
	src/ltlparse/Makefile.am, src/ltlparse/ltlparse.yy,
	src/ltltest/Makefile.am, src/ltltest/defs.in,
	src/ltltest/equals.cc, src/ltltest/equals.test,
	src/ltltest/lunabbrev.test, src/ltltest/nenoform.test,
	src/ltltest/parse.test, src/ltltest/parseerr.test,
	src/ltltest/randltl.cc, src/ltltest/readltl.cc,
	src/ltltest/reduccmp.test, src/ltltest/syntimpl.cc,
	src/ltltest/syntimpl.test, src/ltltest/tostring.cc,
	src/ltltest/tostring.test, src/ltltest/tunabbrev.test,
	src/ltltest/tunenoform.test, src/ltlvisit/basicreduce.cc,
	src/ltlvisit/clone.cc, src/ltlvisit/clone.hh,
	src/ltlvisit/contain.cc, src/ltlvisit/destroy.cc,
	src/ltlvisit/destroy.hh, src/ltlvisit/lunabbrev.cc,
	src/ltlvisit/nenoform.cc, src/ltlvisit/randomltl.cc,
	src/ltlvisit/reduce.cc, src/ltlvisit/syntimpl.cc,
	src/ltlvisit/tostring.cc, src/misc/bddalloc.cc,
	src/misc/bddop.cc, src/misc/bddop.hh, src/misc/freelist.hh,
	src/misc/hash.hh, src/misc/minato.cc, src/misc/minato.hh,
	src/misc/optionmap.cc, src/misc/timer.cc, src/misc/timer.hh,
	src/saba/Makefile.am, src/saba/explicitstateconjunction.cc,
	src/saba/explicitstateconjunction.hh, src/saba/saba.cc,
	src/saba/saba.hh, src/saba/sabacomplementtgba.cc,
	src/saba/sabacomplementtgba.hh, src/saba/sabastate.hh,
	src/saba/sabasucciter.hh, src/sabaalgos/Makefile.am,
	src/sabaalgos/sabadotty.cc, src/sabaalgos/sabadotty.hh,
	src/sabaalgos/sabareachiter.cc, src/sabaalgos/sabareachiter.hh,
	src/sabatest/Makefile.am, src/sabatest/defs.in,
	src/sanity/Makefile.am, src/tgba/Makefile.am,
	src/tgba/bdddict.cc, src/tgba/bddprint.cc,
	src/tgba/formula2bdd.cc, src/tgba/state.hh,
	src/tgba/succiterconcrete.cc, src/tgba/taatgba.hh,
	src/tgba/tgba.hh, src/tgba/tgbabddconcretefactory.cc,
	src/tgba/tgbabddconcretefactory.hh, src/tgba/tgbacomplement.cc,
	src/tgba/tgbacomplement.hh, src/tgba/tgbaexplicit.cc,
	src/tgba/tgbaexplicit.hh, src/tgba/tgbaproduct.cc,
	src/tgba/tgbareduc.cc, src/tgba/tgbareduc.hh,
	src/tgba/tgbasafracomplement.cc, src/tgba/tgbasgba.cc,
	src/tgba/tgbasgba.hh, src/tgba/tgbaunion.cc,
	src/tgba/tgbaunion.hh, src/tgbaalgos/dupexp.cc,
	src/tgbaalgos/eltl2tgba_lacim.cc,
	src/tgbaalgos/eltl2tgba_lacim.hh, src/tgbaalgos/emptiness.cc,
	src/tgbaalgos/gtec/gtec.cc, src/tgbaalgos/ltl2taa.cc,
	src/tgbaalgos/ltl2taa.hh, src/tgbaalgos/ltl2tgba_lacim.cc,
	src/tgbaalgos/neverclaim.cc, src/tgbaalgos/neverclaim.hh,
	src/tgbaalgos/powerset.cc, src/tgbaalgos/reachiter.cc,
	src/tgbaalgos/reachiter.hh, src/tgbaalgos/reductgba_sim.cc,
	src/tgbaalgos/reductgba_sim.hh,
	src/tgbaalgos/reductgba_sim_del.cc, src/tgbaalgos/stats.cc,
	src/tgbaalgos/stats.hh, src/tgbaparse/Makefile.am,
	src/tgbaparse/tgbaparse.yy, src/tgbatest/Makefile.am,
	src/tgbatest/bddprod.test, src/tgbatest/complementation.cc,
	src/tgbatest/complementation.test, src/tgbatest/defs.in,
	src/tgbatest/dfs.test, src/tgbatest/dupexp.test,
	src/tgbatest/explicit.cc, src/tgbatest/explicit.test,
	src/tgbatest/explpro3.test, src/tgbatest/explpro4.test,
	src/tgbatest/explprod.cc, src/tgbatest/explprod.test,
	src/tgbatest/ltl2neverclaim.test, src/tgbatest/ltl2tgba.cc,
	src/tgbatest/ltl2tgba.test, src/tgbatest/ltlprod.cc,
	src/tgbatest/ltlprod.test, src/tgbatest/mixprod.cc,
	src/tgbatest/mixprod.test, src/tgbatest/powerset.cc,
	src/tgbatest/readsave.cc, src/tgbatest/readsave.test,
	src/tgbatest/reduccmp.test, src/tgbatest/reductgba.cc,
	src/tgbatest/reductgba.test, src/tgbatest/taatgba.cc,
	src/tgbatest/tgbaread.cc, src/tgbatest/tgbaread.test,
	src/tgbatest/tripprod.cc, src/tgbatest/tripprod.test,
	wrap/python/cgi/ltl2tgba.in, wrap/python/tests/ltl2tgba.py,
	wrap/python/tests/ltlparse.py, wrap/python/tests/ltlsimple.py:
	Fix copyrights.

1479
1480
1481
1482
2010-01-24  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbaalgos/ltl2tgba_fm.cc: More comments.

Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
1483
1484
2010-01-24  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

1485
1486
1487
1488
1489
1490
1491
1492
	Check that all directories are documented.

	* src/sanity/readme.test: For each AC_OUTPUT Makefile, check that
	the directory is documented in README.  Also skip non distributed
	directories in readme.test.
	* README: Fit on 80 columns.

2010-01-24  Alexandre Duret-Lutz  <adl@lrde.epita.fr>
1493

Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
1494
1495
	* README: Typo.

1496
1497
1498
1499
2010-01-24  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/sanity/Makefile.am (EXTRA_DIST): Distribute readme.test.

1500
1501
1502
1503
1504
2010-01-24  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* README: Add descriptions for subdirectories of bench/, src/sanity,
	and src/kripke.

1505
1506
1507
1508
1509
1510
1511
2010-01-24  Guillaume Sadegh  <sadegh@lrde.epita.fr>

	* src/sanity/readme.test: A script to check whether all the
	directories referenced in README exist.
	* src/sanity/Makefile.am: Adjust to call `readme.test' when make
	check is invoked.

Guillaume Sadegh's avatar
Guillaume Sadegh committed
1512
1513
1514
1515
1516
1517
1518
2010-01-24  Guillaume Sadegh  <sadegh@lrde.epita.fr>

	Update the README.

	* README: Reference src/saba/, src/sabaalgos/, src/sabatest/,
	iface/nips/, iface/nips/nipstest/ and iface/nips/nips_vm/.

1519
1520
1521
1522
1523
1524
1525
1526
1527
2010-01-22  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Turn parse_error_list into an opaque type for Swig.  This
	kills a memory leak warning from swig/python.

	* src/ltlparse/public.hh (parse_error_list): Declare
	as an empty struct for Swig.
	* wrap/python/tests/ltlparse.py: Fix copyright.

1528
1529
1530
1531
1532
1533
1534
1535
2010-01-22  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix the computation of the length of multops.

	* src/ltlvisit/length.cc (visit(multop*)): New function. "a & b &
	c" has length 5, not 4, even though it is stored as And(a,b,c).
	This caused reduc.test to fail on some formulae.

1536
1537
1538
1539
1540
1541
1542
2010-01-21  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Please the style checks...

	* src/tgbaalgos/randomgraph.cc: Fix the copyright and make it fit
	on 80 columns.

1543
1544
1545
1546
1547
2010-01-21  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/ltltest/reduc.cc (main): Fix harmless memory leak introduced
	today.

1548
1549
1550
1551
1552
1553
1554
2010-01-21  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix taa_tgba_formula's destructor.

	* src/tgba/taatgba.cc (taa_tgba_formula::~taa_tgba_formula):
	Really destroy all formulae, not only half of them.

1555
1556
1557
1558
2010-01-21  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbatest/randtgba.cc: Do not include <string> twice.

1559
1560
1561
1562
2010-01-21  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Speedup reduc.test by not spawning one process per formula.

1563
	* src/ltltest/reduc.cc: Add an option -f to read a lot of
1564
1565
1566
1567
	formulae from a file.  Running a process for each formula was
	too slow.  Also add an option -h to hide reduced formulae.
	* src/ltltest/reduc.test: Simplify accordingly.

1568
1569
1570
1571
1572
1573
1574
1575
2010-01-21  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Move the last test from emptchk.test to emptchke.test.

	* src/tgbatest/emptchk.test: Move the newly added test ...
	* src/tgbatest/emptchke.test: ... here, with other explicit test.
	Also test more algorithms.

1576
1577
1578
1579
1580
1581
1582
1583
2010-01-21  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix a memory leak in Cou99 statistics.

	* src/tgbaalgos/gtec/ce.cc (couvreur99_check_result::acss_states):
	Delete the iterator after using it.
	* src/tgbatest/emptchkr.test: Run 'randtgba -z' with valgrind too.

1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
2010-01-21  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix a longstanding bug in our implementation of GV04.

	* src/tgbaalgos/gv04.cc (push): Fix the tracking of the accepting
	link.  This bug was discovered on a random generated graph with
	a complex accepting cycle.
	* src/tgbatest/emptchk.test: Add the troublesome graph as
	test case.

1594
1595
1596
1597
1598
1599
1600
1601
2010-01-20  Damien Lefortier <dam@lrde.epita.fr>

	When iterating a hash_map, be careful not to delete i->first
	before doing ++i to avoid memory issues.

	* src/tgba/taatgba.cc, src/tgba/taatgba.hh,
	src/tgba/tgbaexplicit.cc, src/tgba/tgbaexplicit.hh: Fix them.

1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
2010-01-20  Damien Lefortier <dam@lrde.epita.fr>

	Minor fixes to compile with GCC 3.3

	* src/ltlast/automatop.cc, src/ltlast/automatop.hh: Rename nfa as
	get_nfa to avoid a name clash with the `nfa' class.
	* src/ltlvisit/clone.cc, src/ltlvisit/nenoform.cc,
	src/ltlvisit/tostring.cc, src/tgbaalgos/eltl2tgba_lacim.cc: Use
	get_nfa instead of nfa.
	* src/tgba/tgbasafracomplement.cc: Don't use a
	const_reverse_iterator.

1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
2010-01-20  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Remove some non-determinism in random_graph()

	* src/tgbaalgos/randomgraph.cc (random_graph): Revert the part of
	the patch from 2007-02-06 which silently replaced the use of state
	index by state pointers.  Storing states pointer in this map cause
	some non-determinism because of the memory layout.  It was almost
	impossible to reproduce bugs found by tests based on randtgba.

1624
2010-01-19  Damien Lefortier <dam@lrde.epita.fr>
1625
1626
1627

	* src/tgbaalgos/ltl2taa.cc: Fix the previous patch.

1628
1629
1630
1631
1632
1633
1634
2010-01-18  Damien Lefortier <dam@lrde.epita.fr>

	* src/tgba/taatgba.cc, src/tgba/taatgba.hh: Fix memory issues
	occuring when labels are pointers.
	* src/tgbaalgos/ltl2taa.cc: Fix a bug.
	* src/tgbatest/ltl2tgba.cc: Fix a bug.

1635
1636
1637
1638
2010-01-16  Guillaume Sadegh  <sadegh@lrde.epita.fr>

	* src/saba/sabacomplementtgba.cc: Fix a bug.

1639
1640
1641
1642
1643
1644
1645
1646
1647
2010-01-16  Damien Lefortier <dam@lrde.epita.fr>

	Use taa_tgba_formula instead of taa_tgba_string in ltl_to_taa to
	speed up a little the translation.

	* src/tgbaalgos/ltl2taa.cc: Adjust.  Also fix a bug with
	acceptance conditions in all_n_tuples.
	* src/tgba/taatgba.cc, src/tgba/taatgba.hh: Adjust.

1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
2010-01-16  Damien Lefortier <dam@lrde.epita.fr>

	Introduce taa_tgba_labelled<label> so that we can build
	taa_tgba instances labelled by other objects than strings
	in the same way Alexandre did for tgba_explicit.

	* src/tgba/taatgba.cc, src/tgba/taatgba.hh: Split taa_tgba in two
	levels: taa_tgba with no label and taa_tgba_labelled templated by
	the type of the label.  Define taa_tgba_string (with the interface
	of the former taa_tgba class) and taa_tgba_formula for future use
	in ltl2taa.cc.
	* src/tgbaalgos/ltl2taa.cc, src/tgbatest/taatgba.cc: Adjust to use
	taa_tgba_string.

1662
1663
1664
1665
1666
1667
2010-01-06  Damien Lefortier <dam@lrde.epita.fr>

	Fix a longstanding bug reported by Guillaume Sadegh.

	* src/eltlparse/eltlscan.ll: Fix a typo.

1668
1669
1670
1671
1672
1673
1674
1675
1676
2010-01-05  Damien Lefortier <dam@lrde.epita.fr>

	Merge eltl2tgba.cc into ltl2tgba.cc.

	* src/tgbatest/eltl2tgba.cc: Remove.
	* src/tgbatest/Makefile.am: Adjust.
	* src/tgbatest/ltl2tgba.cc: New option: -xltl to translate an
	extended LTL instead of an LTL, a feature previously offered by
	eltl2tgba.cc. Also: -R3b to use delete_unaccepting_scc.
1677
	* src/tgbatest/spotlbtt.test, src/tgbatest/eltl2tgba.test: Adjust.
1678

1679
1680
1681
1682
1683
1684
2009-11-10  Damien Lefortier <dam@lrde.epita.fr>

	* src/tgba/tgbabddcoredata.cc (delete_unaccepting_scc): Fix a bug.
	* src/tgbatest/spotlbtt.test: Use the above function with LaCIM
	for ELTL which greatly reduce the size of the automata!

1685
1686
1687
1688
2009-12-11  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/misc/timer.hh (timer::timer): Initialize running...

1689
1690
1691
1692
1693
2009-12-09  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/Makefile.am (SUBDIRS): Fix missing ".", mistakenly removed
	by previous patch.

1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
2009-11-30  Guillaume Sadegh  <sadegh@lrde.epita.fr>

	An algorithm to complement TGBA into SABA.

	* src/saba/sabacomplementtgba.hh,
	src/saba/sabacomplementtgba.cc: New.  The algorithm.
	* src/saba/Makefile.am: Adjust.
	* src/sabatest/sabacomplementtgba.cc, src/sabatest/Makefile.am,
	src/sabatest/defs.in: New.  Test the algorithm.
	* configure.ac, src/Makefile.am: Adjust to the new directory
	`sabatest'.

1706
1707
2009-11-30  Guillaume Sadegh  <sadegh@lrde.epita.fr>

1708
	Add a new type of automata: State-labeled Alternating Büchi
1709
1710
1711
1712
	Automata (SABA).

	* src/saba/saba.hh, src/saba/saba.cc, src/saba/sabastate.hh,
	src/saba/sabasucciter.hh: New.  Interface for
1713
	SABA (State-labeled Alternating Büchi Automata).
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
	* src/saba/explicitstateconjunction.cc,
	src/saba/explicitstateconjunction.hh: New.  Default
	implementation for a conjunction of states.
	* src/saba/Makefile.am: New.
	* src/Makefile.am, configure.ac: Adjust.
	* src/sabaalgos/sabareachiter.cc,
	src/sabaalgos/sabareachiter.hh: New.  Iterate over all reachable
	states of a spot::saba.
	* src/sabaalgos/sabadotty.cc, src/sabaalgos/sabadotty.hh: New.
	Print reachable states in dot format.
	* src/sabaalgos/Makefile.am: New.

1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
2009-11-27  Guillaume Sadegh  <sadegh@lrde.epita.fr>

	Rename the class taa as taa_tgba.

	* src/tgba/taa.cc, src/tgba/taa.hh: Rename as ...
	* src/tgba/taatgba.cc, src/tgba/taatgba.hh: ... these, and
	rename the class taa as taa_tgba.
	* src/tgbaalgos/ltl2taa.cc, src/tgbaalgos/ltl2taa.hh,
	src/tgbaalgos/Makefile.am: Adjust.
	* src/tgbatest/ltl2tgba.cc, src/tgbatest/Makefile.am: Adjust.
	* src/tgbatest/taa.test: Rename as ...
	* src/tgbatest/taatgba.test ... this.
	* src/tgbatest/taa.cc: Rename as ...
	* src/tgbatest/taatgba.cc ... this, and adjust.

1741
1742
1743
1744
1745
2009-11-26  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbatest/ltl2tgba.cc (main): Fix typo to re-enable
	reductions by simulation.

1746
1747
1748
1749
1750
2009-11-26  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* m4/buddy.m4 (AX_CHECK_BUDDY): Check for bdd_satprefix, the
	latest function added to BuDDy.

1751
1752
1753
1754
1755
2009-11-25  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbatest/ltl2tgba.cc (main): Stop the SCC timer.  I mean
	really stop it!

1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
2009-11-24  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Detect running timers, and stop a timer in ltl2tgba.

	* src/misc/timer.hh (time_info::running): New attribute.
	(time_info::start, time_info::stop): Update and check
	time_info::running.
	* src/misc/timer.cc (timer_map::print): Mark running timers with
	a "+" in the output.
	* src/tgbatest/ltl2tgba.cc (main): Rename the name of the timers
	for SCC and simulation reduction, and actually stop the SCC timer.

1768
1769
1770
1771
1772
2009-11-23  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbaalgos/sccfilter.cc (create_transition): Do not clone
	the same node twice when dealing with loops.

1773
1774
1775
1776
1777
1778
1779
1780
2009-11-23  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Use bdd_satprefix() to speedup minato on BDDs that are almost cubes.

	* src/misc/minato.cc (minato_isop::minato_isop): Call bdd_satprefix.
	(minato_isop::next): Avoid useless intermediate variables.
	* src/misc/minato.hh: Typo in comments.

1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
2009-11-23  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Specialize scc_filter when handling tgba_explicit_formula automata.

	If the input is a tgba_explicit_formula we can output a
	tgba_explicit_formula too, and we want to do that because it is
	more space efficient.

	* src/tgba/tgbaexplicit.hh (get_label): New method.
	* src/tgbaalgos/sccfilter.cc (create_transition): New function,
	to handle tgba_explicit_formula and tgba_explicit_string output
	differently.
	(filter_iter): Template it on the output tgba type, and adjust
	to call create_transition.
	(scc_filter): Use filter_iter<tgba_explicit_formula> or
	filter_iter<tgba_explicit_string> depending on the input tgba
	type.

1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
2009-11-20  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Strip useless acceptance conditions in scc_filter().

	A useless acceptance conditions is one that is always implied by
	another.

	* src/misc/bddop.hh, src/misc/bddop.cc
	(compute_neg_acceptance_conditions): New function.
	* src/tgba/tgbaexplicit.hh, src/tgba/tgbaexplicit.cc
	(set_acceptance_conditions): New function.
	* src/tgbaalgos/scc.cc (build_map, build_scc_stats, dump_scc_dot):
	Keep track of useful acceptance conditions.
	(useful_acc_of): New function.
	* src/tgbaalgos/scc.hh (scc_stats, scc_map::scc::useful_scc): New
	attributes.
	* src/tgbaalgos/sccfilter.cc (filter_iter): Adjust to filter
	useless acceptance conditions.
	(scc_filter): Compute useful acceptance conditions and pass them
	to filter_iter.

1820
1821
1822
1823
1824
2009-11-20  Alexandre Duret-Lutz  <adl@va-et-vient.net>

	* src/tgbaalgos/sccfilter.cc (scc_filter): Merge transitions
	after removing acceptance conditions.

1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
2009-11-18  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Remove prune_scc(), prune_acc(), and related fonctions.

	* src/tgba/tgbareduc.cc, src/tgba/tgbareduc.hh (prune_scc,
	prune_acc, remove_component, compute_scc, remove_acc,
	is_not_accepting, delete_scc, is_terminal, remove_scc,
	display_scc): Remove anything related to the simplification of
	SCCs.

1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
2009-11-18  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Replace prune_scc() by scc_filter().

	prune_scc() leaked memory and failed to remove chains of useless SCCs.

	* src/tgbaalgos/reductgba_sim.cc (reduc_tgba_sim): Call
	scc_filter() instead of prune_scc(), and do it before running
	any simulation-based reduction.
	* src/tgbaalgos/reductgba_sim.hh (reduc_tgba_sim): Return a const
	tgba*.
	* src/tgbatest/ltl2tgba.cc, src/tgbatest/reductgba.cc: Call
	scc_filter() instead of prune_scc().
	* src/tgbatest/scc.test: Add two more tests that failed with
	prune_scc().

1851
1852
1853
1854
1855
1856
1857
1858
2009-11-18  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Quick implementation of a "useless SCC" filter using scc_map.

	* src/tgbaalgos/sccfilter.hh, src/tgbaalgos/sccfilter.cc: New
	files.
	* src/tgbaalgos/Makefile.am: Add them.

1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
2009-11-18  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix acceptance check in scc_map: trivial SCCs are not accepting.
	Also compute useless SCCs.

	* src/tgbaalgos/scc.cc (scc_map::scc::trivial): New field.
	(scc_stats::useless_scc_map): New field.
	* src/tgbaalgos/scc.cc (scc_map::build_map): Mark SCCs that are
	not trivial.
	(scc_map::accepting): Always return false for trivial SCC.
	(build_scc_stats): Fill in useless_scc_map.

1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
2009-11-18  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Make it easy to filter states while iterating over an automaton.

	* src/tgbaalgos/reachiter.hh (tgba_reachable_iterator::want_state):
	New method.
	* src/tgbaalgos/reachiter.cc (tgba_reachable_iterator::want_state):
	Implement it.
	(tgba_reachable_iterator::run): Call want_state before processing
	a state.

1882
1883
1884
1885
1886
1887
1888
2009-11-17  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbaalgos/cutscc.cc (cut_scc): Pass `s' by reference instead
	of by pointer.
	* src/tgbaalgos/cutscc.cc, src/tgbaalgos/cutscc.hh: Fix copyright
	header.

1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
2009-11-13  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Replace the hash key construction of LTL formulae by a simple
	counter updated each time we create a new (unique) formula.

	Doing so saves a lot of memory during the translation of the
	ltlcounter formulae, because the formulae are quite big and
	storing a string representation of each formula on its node was a
	bad idea.  For instance with n=12, the translation now uses 40MB
	where it used 290MB.  (Note: in both cases, 20MB is being used by
	the BDD cache.)

	* src/ltlast/formula.hh (hash_key_): Rename as ...
	(count_): ... this.
	(hash): Adjust.
	(max_count): New static variable to count the number of
	formulae created.
	(formula): Update max_count and set count_.
	(dump): Make it a virtual pure method.
	(set_key_): Remove.
	(formula_ptr_less_than): Speed up and return false when
	the two formula pointer are equal.
	* src/ltlast/formula.cc (set_key_, dump): Remove.
	* src/ltlast/atomic_prop.cc, src/ltlast/atomic_prop.hh,
	src/ltlast/automatop.cc, src/ltlast/automatop.hh,
	src/ltlast/binop.cc, src/ltlast/binop.hh, src/ltlast/constant.cc,
	src/ltlast/constant.hh, src/ltlast/multop.cc,
	src/ltlast/multop.hh, src/ltlast/unop.cc, src/ltlast/unop.hh:
	Empty the constructor (do not precompute the dump_ anymore),
	and add a dump() implementation.

1920
1921
1922
1923
1924
1925
1926
1927
2009-11-12  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Use -l wherever we where expecting ltl2tgba to default to LaCIM.

	* bench/ltl2tgba/algorithms: Use -l for all LaCIM invocations.
	* src/tgbatest/dupexp.test, src/tgbatest/emptchk.test,
	src/tgbatest/spotlbtt.test: Likewise.

1928
1929
1930
1931
1932
1933
1934
1935
2009-11-12  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Cleanup the help of ltl2tgba.

	* src/tgbatest/ltl2tgba.cc (syntax): Reorganize the help text, so
	that we can find options without resorting to grep...  Also
	cleanup the program name if it is a libtool wrapper.

1936
1937
1938
1939
1940
1941
1942
1943
2009-11-12  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbatest/ltl2tgba.cc (-l): New option to select the lacim
	translation.  It still is the default translation.
	(opt_fm, opt_taa): Replace these two variables by ...
	(translation): ... this enum.  And use a switch to call the
	correct translation.

1944
1945
1946
1947
1948
1949
2009-11-11  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Remove python bindings for ltl::clone and ltl::destroy.

	* wrap/python/spot.i: Do not include clone.hh and destroy.hh.

1950
1951
1952
1953
1954
1955
1956
2009-11-10  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Typo from a previous patch.

	* src/tgbaalgos/ltl2tgba_fm.cc (ltl_to_tgba_fm): Fix a typo
	introduced three patches ago in the handling of unobserved events.

1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
2009-11-10  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Do not comment states in the never claim by default.  It takes too
	much time when the formula is large, and it is useless when the
	purpose is model-checking with Spin.

	* src/tgbaalgos/neverclaim.hh (never_claim_reachable): Add the
	comments option.
	* src/tgbaalgos/neverclaim.cc (never_claim_bfs,
	never_claim_reachable): Honor the comment option.
	* src/tgba/tests/ltl2tgba.cc (-N): Do not comment states.
	(-NN) New option to output a commented never claim.

1970
1971
1972
1973
1974
1975
1976
2009-11-10  Damien Lefortier <dam@lrde.epita.fr>

	* src/tgba/taa.cc, src/tgba/taa.hh: Fix it.
	* src/tgbaalgos/ltl2taa.cc: Do NOT use the same bdd_dict for both
	the translation and the language containment checker.
	* src/tgbatest/spotlbtt.test: Update TAA related tests.

1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
2009-11-10  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Use tgba_explicit_formula instead of tgba_explicit_string in FM.

	This gives a nice speedup (>1.4) in the ltlcounter benchmark,
	because we no longer have to generate a copy the string
	representations of the LTL formulae.

	* src/tgbaalgos/ltl2tgba_fm.cc: Adjust.  Also get rid of the
	formulae_seen map, since we can now ask the tgba_explicit_formula
	if it knows the state.

1989
1990
1991
1992
1993
1994
1995
2009-11-10  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Ease debugging of LTL formulae leaks.

	* src/tgbatest/ltl2tgba.cc: Dump all LTLinstances with their
	reference count.

1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2009-11-10  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Introduce tgba_explicit_labelled<label> so that we can build
	tgba_explicit instances labelled by other objects than strings.

	* src/tgba/tgbaexplicit.cc, src/tgba/tgbaexplicit.hh:
	Split tgba_explicit in two levels: tgba_explicit with unlabelled
	states, and tgba_explicit_labelled templated by the type of
	the label.  Define tgba_explicit_string (with the interface
	of the former tgba_explicit class) and tgba_explicit_formula
	for future use in ltl2tgba.cc.
	* src/tgba/tgbareduc.cc, src/tgba/tgbareduc.hh,
	src/tgbaalgos/cutscc.cc, src/tgbaalgos/dupexp.cc,
	src/tgbaalgos/emptiness.cc, src/tgbaalgos/ltl2tgba_fm.cc,
	src/tgbaalgos/powerset.cc, src/tgbaalgos/randomgraph.cc,
	src/tgbaparse/public.hh, src/tgbaparse/tgbaparse.yy,
	src/tgbatest/explicit.cc, src/tgbatest/ltl2tgba.cc: Adjust to
	use tgba_explicit_string when appropriate.

2015
2016
2017
2018
2019
2020
2009-11-09  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Do not use the Boost macro from the Autoconf macro archive.

	* m4/boost.m4: Rewrite like I already did in Vaucanson.

2021
2022
2023
2024
2025
2009-11-09  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbatest/ltlcounter.test (run): Do not run with n=12, as
	the test case might become too slow for the autobuilder.

2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2009-11-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Add a benchmark using Kristin Y. Rozier's LTLcounter scripts.

	* bench/ltlcounter/README, bench/ltlcounter/run,
	bench/ltlcounter/plot.gnu, bench/ltlcounter/defs.in,
	bench/ltlcounter/Makefile.am: New files.
	* bench/Makefile.am (SUBDIRS): Add ltlcounter.
	* configure.ac (AC_CONFIG_FILES): Adjust.
	* THANKS: Add her.

2037
2038
2039
2040
2041
2042
2009-11-06  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Use a timer to clock the different phases of the translation.

	* src/tgbatest/ltl2tgba.cc: Add option -T.

2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2009-11-08  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Deprecate ltl::destroy(f) in favor of f->destroy()

	* src/ltlast/formula.cc, src/ltlast/formula.hh (formula::clone):
	Transform this static function into a member function.
	* src/ltlvisit/destroy.hh (destroy): Document and declare as
	deprecated.
	* bench/split-product/cutscc.cc, iface/gspn/ltlgspn.cc,
	src/eltlparse/eltlparse.yy, src/eltltest/acc.cc,
	src/evtgbaalgos/tgba2evtgba.cc, src/evtgbatest/ltl2evtgba.cc,
	src/ltlast/automatop.cc, src/ltlast/binop.cc,
	src/ltlast/multop.cc, src/ltlast/unop.cc, src/ltlenv/declenv.cc,
	src/ltlenv/declenv.hh, src/ltlparse/ltlparse.yy,
	src/ltltest/equals.cc, src/ltltest/randltl.cc,
	src/ltltest/readltl.cc, src/ltltest/reduc.cc,
	src/ltltest/syntimpl.cc, src/ltltest/tostring.cc,
	src/ltlvisit/destroy.cc src/ltlvisit/basicreduce.cc,
	src/ltlvisit/contain.cc, src/ltlvisit/reduce.cc,
	src/ltlvisit/syntimpl.cc, src/tgba/bdddict.cc,
	src/tgba/bddprint.cc, src/tgba/taa.cc,
	src/tgba/tgbabddconcretefactory.cc, src/tgba/tgbaexplicit.cc,
	src/tgba/tgbafromfile.cc, src/tgbaalgos/eltl2tgba_lacim.cc,
	src/tgbaalgos/ltl2taa.cc, src/tgbaalgos/ltl2tgba_fm.cc,
	src/tgbaalgos/ltl2tgba_lacim.cc, src/tgbaalgos/neverclaim.cc,
	src/tgbaalgos/randomgraph.cc, src/tgbaparse/tgbaparse.yy,
	src/tgbatest/complementation.cc, src/tgbatest/eltl2tgba.cc,
	src/tgbatest/ltl2tgba.cc, src/tgbatest/ltlprod.cc,
	src/tgbatest/mixprod.cc, src/tgbatest/randtgba.cc,
	src/tgbatest/reductgba.cc, wrap/python/cgi/ltl2tgba.in,
	wrap/python/tests/ltl2tgba.py, wrap/python/tests/ltlparse.py,
	wrap/python/tests/ltlsimple.py: Adjust destroy() usage, and remove
	the #include "destroy.hh" when appropriate.

2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2009-11-08  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Deprecate ltl::clone(f) in favor of f->clone().

	* src/ltlvisit/clone.hh (clone): Document and declare as deprecated.
	* src/ltlast/formula_tree.cc, src/ltlvisit/basicreduce.cc,
	src/ltlvisit/clone.cc, src/ltlvisit/contain.cc,
	src/ltlvisit/lunabbrev.cc, src/ltlvisit/reduce.cc,
	src/ltlvisit/syntimpl.cc, src/tgba/bdddict.cc,
	src/tgba/formula2bdd.cc, src/tgba/tgbabddconcretefactory.cc,
	src/tgbaalgos/ltl2taa.cc, src/tgbaalgos/ltl2tgba_fm.cc,
	src/tgbatest/complementation.cc, wrap/python/tests/ltlsimple.py:
	Adjust clone() usage, and remove the #include "clone.hh" when
	appropriate.

2092
2093
2094
2095
2096
2097
2098
2009-11-08  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Make it possible to clone const formulae.

	* src/ltlast/formula.hh, src/ltlast/formula.cc (clone): Declare
	as const.

2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2009-11-08  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Rename formula::ref and formula::unref as formula::clone
	and formula::destroy.

	* src/ltlast/atomic_prop.cc, src/ltlast/automatop.cc,
	src/ltlast/binop.cc, src/ltlast/formula.hh, src/ltlast/formula.cc,
	src/ltlast/multop.cc, src/ltlast/unop.cc, src/ltlenv/declenv.cc,
	src/ltlvisit/basicreduce.cc, src/ltlvisit/clone.cc,
	src/ltlvisit/destroy.cc, src/ltlvisit/nenoform.cc,
	src/ltlvisit/randomltl.cc, src/ltlvisit/reduce.cc,
	src/tgbatest/randtgba.cc: Adjust.

2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2009-11-07  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Change the way references are counted to speedup cloning.

	Before this patch, every time you cloned a formula, the clone
	visitor would recurse into the entire AST to increment the
	reference count of all nodes.  When running ltl2tgba_fm on
	the formula generated by "LTLcounterLinear.pl 8", approx 27% of
	the time was spent in the clone visitor.

	After this patch, cloning a formula is just an increment of the
	reference count of the top node.  Children are decremented only
	when the top node's ref count is decremented to zero.  With this
	change, clone() and destroy() become constant time, the
	ltl2tgba_fm spend only 0.01% of the time cloning formulae.


	* src/ltlast/automatop.cc (~automatop): Decrement children.
	(instance): Decrement children if the instance already exists.
	* src/ltlast/binop.cc, src/ltlast/multop.cc, src/ltlast/unop.cc:
	Likewise.
	* src/ltlvisit/clone.cc (clone): Simplify, now we only need to
	call ref().
	* src/ltlvisit/destroy.cc (destroy): Simplify, now we only need
	to call unref().
	(destroy_visitor): Remove, no longer needed.

2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2009-11-07  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Make it easier to debug reference counts in LTL nodes.

	* src/ltlast/automatop.cc, src/ltlast/automatop.hh,
	src/ltlast/binop.cc, src/ltlast/binop.hh, src/ltlast/multop.cc,
	src/ltlast/multop.hh, src/ltlast/unop.cc, src/ltlast/unop.hh:
	Add a dump_instance() static method to all class.
	* src/ltltest/readltl.cc: Add option -r to dump all instances
	with their reference count, after parsing and after deletion.

2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2009-11-07  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Better types for instance maps.

	* src/ltlast/unop.hh (map): Use unop* as values.
	* src/ltlast/binop.hh (map): Use binop* as values.
	* src/ltlast/multop.hh (map): Use multop* as values.
	* src/ltlast/automatop.hh (paircmp): Rename as tripletcmp.
	(map): Use automaton* as values, not formula*.

2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2009-11-07  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Add missing instance_count() in automatop and eltl2tgba.

	* src/ltlast/automatop.hh, src/ltlast/automatop.cc: Add missing
	instance_count() functions.
	* src/tgbatests/eltl2tgba.cc: Add missing instance_count()
	assertions at the end.
	* src/tgbatests/ltl2tgba.cc: Also call automatop::instance_count(),
	even if automatop are not used in ltl2tgba yet.  This way we won't
	forget once eltl2tgba and ltl2tgba are merged.

2172
2173
2174
2175
2009-11-07  Damien Lefortier <dam@lrde.epita.fr>

	* src/tgba/taa.cc, src/tgbatest/taa.cc: Adjust.

2176
2177
2178
2179
2180
2181
2009-11-07  Damien Lefortier <dam@lrde.epita.fr>

	* src/tgba/taa.cc, src/tgba/taa.hh: Speed up the cartesian product
	in taa_succ_iterator and allow multiple initial states in taa.
	* src/tgba/ltl2taa.cc: Remove temporary printing.

2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2009-11-05  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix ltlcounter.test for VPATH builds and n > 2.

	* src/tgbatest/defs.in (srcdir): Adjust from VPATH builds.
	* src/tgbatest/ltlcounter.test (lcdir): Adjust definition to
	new value of $srcdir.
	(run): Fix setting of $run after $n = 2.  Using run=: would in
	fact disable all the big tests...

2192
2193
2194
2195
2196
2197
2009-11-05  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbatest/ltlcounter.test (run): Only construct small
	formulae (i.e. n<=2) under valgrind.  The test case is too
	slow otherwise.

2198
2199
2200
2201
2202
2203
2204
2009-11-04  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix spurious failure of style.test.

	* src/sanity/style.test: Make sure sh does not abort when read
	exits with false.

2205
2206
2009-11-04  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

2207
	Fix a longstanding bug reported by Kristin Y. Rozier.
2208
2209
2210
2211
2212
2213
2214
2215

	* src/ltlast/formula.hh (formula_ptr_less_than::operator()):
	Fix a typo where `l' was typed as `1'.
	* src/tgbatest/ltlcounter/: New files from Kristin Y. Rozier.
	* src/tgbatest/ltlcounter.test: New
	* src/tgbatest/Makefile.am (TESTS): Add ltlcounter.test.
	(EXTRA_DIST): Add files in ltlcounter/.

2216
2217
2218
2219
2220
2221
2222
2009-11-03  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Fix the help text of ltl2tgba.

	* src/tgbatest/ltl2tgba.cc (syntax): Add missing std::endl
	before -taa.  Remove -r8 and -fr8, since they do not exist.

2223
2224
2225
2226
2227
2228
2229
2009-10-28  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgba/tgbacomplement.cc (state_complement): Remove the copy
	constructor.  It does the same thing as the default copy
	constructor, and g++ 4.2.3 complained that the copy constructor
	of spot::state was not called.  Reported by Denis Poitrenaud.

2230
2231
2232
2233
2234
2235
2009-10-28  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/ltlast/formula_tree.cc (instanciate, arity): Add a useless
	return 0 at the end to prevent g++ 4.2.3 from complaining about
	a missing return.  Reported by Denis Poitrenaud.

2236
2237
2238
2239
2009-10-23  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbatest/kv.test: Don't run valgrind on dot!

2240
2241
2242
2243
2244
2245
2246
2247
2248
2009-10-16  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	Escape labels in -KV output.

	* src/tgbaalgos/scc.cc (dump_scc_dot): Escape labels and other
	strings output between quote in dot.
	* src/tgbatest/kv.test: New file.
	* src/tgbatest/Makefile.am (TESTS): Add it.

2249
2250
2251
2252
2009-10-16  Alexandre Duret-Lutz  <adl@lrde.epita.fr>

	* src/tgbaalgos/ltl2tgba_fm.cc: Typos.

Damien Lefortier's avatar
Damien Lefortier committed
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2009-10-22  Damien Lefortier <dam@lrde.epita.fr>

	Improve ltl_to_taa.

	* src/tgba/taa.cc, src/tgba/taa.hh: taa_succ_iterator is not
	on-the-fly anymore allowing some redundant transitions to be
	removed. Also a new function to output a TAA.
	* src/tgbaalgos/ltl2taa.cc, src/tgbaalgos/ltl2taa.hh: Add the
	refined rules from Tauriainen.
	* src/tgbatest/ltl2tgba.cc: Use -c to activate refined rules in
	ltl_to_taa.
	* src/tgbatest/spotlbtt.test: More tests.

Damien Lefortier's avatar
Damien Lefortier committed
2266
2267
2268
2269
2270
2271
2009-10-17  Damien Lefortier <dam@lrde.epita.fr>