stutter.cc 15.8 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
// -*- coding: utf-8 -*-
// Copyright (C) 2014, 2015 Laboratoire de Recherche
// et Développement de l'Epita (LRDE).
//
// This file is part of Spot, a model checking library.
//
// Spot is free software; you can redistribute it and/or modify it
// under the terms of the GNU General Public License as published by
// the Free Software Foundation; either version 3 of the License, or
// (at your option) any later version.
//
// Spot is distributed in the hope that it will be useful, but WITHOUT
// ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
// or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public
// License for more details.
//
// You should have received a copy of the GNU General Public License
// along with this program.  If not, see <http://www.gnu.org/licenses/>.

#include "stutter.hh"
21
#include "twa/twa.hh"
22
23
#include "misc/hash.hh"
#include "misc/hashfunc.hh"
24
#include "tl/apcollect.hh"
25
#include "translate.hh"
26
#include "tl/remove_x.hh"
27
28
#include "twaalgos/product.hh"
#include "twaalgos/ltl2tgba_fm.hh"
29
#include "twaalgos/isdet.hh"
30
31
#include "twaalgos/complement.hh"
#include "twaalgos/remfin.hh"
32
33
#include "twa/twaproduct.hh"
#include "twa/bddprint.hh"
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
#include <deque>
#include <unordered_map>
#include <unordered_set>
#include <vector>

namespace spot
{
  namespace
  {
    class state_tgbasl: public state
    {
    public:
      state_tgbasl(state* s, bdd cond) : s_(s), cond_(cond)
      {
      }

      virtual
      ~state_tgbasl()
      {
        s_->destroy();
      }

      virtual int
      compare(const state* other) const
      {
        const state_tgbasl* o =
          down_cast<const state_tgbasl*>(other);
        assert(o);
        int res = s_->compare(o->real_state());
        if (res != 0)
          return res;
        return cond_.id() - o->cond_.id();
      }

      virtual size_t
      hash() const
      {
        return wang32_hash(s_->hash()) ^ wang32_hash(cond_.id());
      }

      virtual
      state_tgbasl* clone() const
      {
        return new state_tgbasl(*this);
      }

      state*
      real_state() const
      {
        return s_;
      }

      bdd
      cond() const
      {
        return cond_;
      }

    private:
      state* s_;
      bdd cond_;
    };

97
    class twasl_succ_iterator : public twa_succ_iterator
98
99
    {
    public:
100
      twasl_succ_iterator(twa_succ_iterator* it, const state_tgbasl* state,
101
102
103
104
105
106
			   bdd_dict_ptr d, bdd atomic_propositions)
        : it_(it), state_(state), aps_(atomic_propositions), d_(d)
      {
      }

      virtual
107
      ~twasl_succ_iterator()
108
109
110
111
112
113
114
115
116
117
118
119
120
121
      {
        delete it_;
      }

      // iteration

      bool
      first()
      {
        loop_ = false;
        done_ = false;
        need_loop_ = true;
        if (it_->first())
          {
122
            cond_ = it_->cond();
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
            next_edge();
          }
        return true;
      }

      bool
      next()
      {
        if (cond_ != bddfalse)
          {
            next_edge();
            return true;
          }
        if (!it_->next())
          {
            if (loop_ || !need_loop_)
              done_ = true;
            loop_ = true;
            return !done_;
          }
        else
          {
145
            cond_ = it_->cond();
146
147
148
149
150
151
152
153
154
155
156
157
158
159
            next_edge();
            return true;
          }
      }

      bool
      done() const
      {
        return it_->done() && done_;
      }

      // inspection

      state_tgbasl*
160
      dst() const
161
162
163
      {
        if (loop_)
          return new state_tgbasl(state_->real_state(), state_->cond());
164
        return new state_tgbasl(it_->dst(), one_);
165
166
167
      }

      bdd
168
      cond() const
169
170
171
172
173
174
175
      {
        if (loop_)
          return state_->cond();
        return one_;
      }

      acc_cond::mark_t
176
      acc() const
177
178
179
      {
        if (loop_)
          return 0U;
180
        return it_->acc();
181
182
183
184
185
186
187
188
189
      }

    private:
      void
      next_edge()
      {
        one_ = bdd_satoneset(cond_, aps_, bddtrue);
        cond_ -= one_;
        if (need_loop_ && (state_->cond() == one_)
190
            && (state_ == it_->dst()))
191
192
193
          need_loop_ = false;
      }

194
      twa_succ_iterator* it_;
195
196
197
198
199
200
201
202
203
204
205
      const state_tgbasl* state_;
      bdd cond_;
      bdd one_;
      bdd aps_;
      bdd_dict_ptr d_;
      bool loop_;
      bool need_loop_;
      bool done_;
    };


206
    class tgbasl final : public twa
207
208
    {
    public:
209
      tgbasl(const const_twa_ptr& a, bdd atomic_propositions)
210
	: twa(a->get_dict()), a_(a), aps_(atomic_propositions)
211
212
213
      {
	get_dict()->register_all_propositions_of(&a_, this);
	assert(acc_.num_sets() == 0);
214
	acc_.add_sets(a_->num_sets());
215
	acc_.set_generalized_buchi();
216
217
218
219
220
221
222
223
224
225
226
227
      }

      virtual ~tgbasl()
      {
	get_dict()->unregister_all_my_variables(this);
      }

      virtual state* get_init_state() const override
      {
	return new state_tgbasl(a_->get_init_state(), bddfalse);
      }

228
      virtual twa_succ_iterator* succ_iter(const state* state) const override
229
230
231
      {
	const state_tgbasl* s = down_cast<const state_tgbasl*>(state);
	assert(s);
232
	return new twasl_succ_iterator(a_->succ_iter(s->real_state()), s,
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
					a_->get_dict(), aps_);
      }

      virtual std::string format_state(const state* state) const override
      {
	const state_tgbasl* s = down_cast<const state_tgbasl*>(state);
	assert(s);
	return (a_->format_state(s->real_state())
		+ ", "
		+ bdd_format_formula(a_->get_dict(), s->cond()));
      }

    protected:
      virtual bdd compute_support_conditions(const state*) const override
      {
	return bddtrue;
      }

    private:
252
      const_twa_ptr a_;
253
254
255
256
257
      bdd aps_;
    };

    typedef std::shared_ptr<tgbasl> tgbasl_ptr;

258
    inline tgbasl_ptr make_tgbasl(const const_twa_ptr& aut, bdd ap)
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
    {
      return std::make_shared<tgbasl>(aut, ap);
    }



    typedef std::pair<unsigned, bdd> stutter_state;

    struct stutter_state_hash
    {
      size_t
      operator()(const stutter_state& s) const
      {
	return wang32_hash(s.first) ^ wang32_hash(s.second.id());
      }
    };

    // Associate the stutter state to its number.
    typedef std::unordered_map<stutter_state, unsigned,
			       stutter_state_hash> ss2num_map;

    // Queue of state to be processed.
    typedef std::deque<stutter_state> queue_t;
  }

284
  twa_graph_ptr
285
  sl(const twa_graph_ptr& a)
286
  {
287
    return sl(a, a->ap_var());
288
289
  }

290
  twa_graph_ptr
291
  sl2(const twa_graph_ptr& a)
292
  {
293
    return sl2(a, a->ap_var());
294
295
  }

296
297
  twa_graph_ptr
  sl(const const_twa_graph_ptr& a, bdd atomic_propositions)
298
299
  {
    // The result automaton uses numbered states.
300
    twa_graph_ptr res = make_twa_graph(a->get_dict());
301
302
    // We use the same BDD variables as the input.
    res->copy_ap_of(a);
303
    res->copy_acceptance_of(a);
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
    // These maps make it possible to convert stutter_state to number
    // and vice-versa.
    ss2num_map ss2num;

    queue_t todo;

    unsigned s0 = a->get_init_state_number();
    stutter_state s(s0, bddfalse);
    ss2num[s] = 0;
    res->new_state();
    todo.push_back(s);

    while (!todo.empty())
      {
	s = todo.front();
	todo.pop_front();
	unsigned src = ss2num[s];

	bool self_loop_needed = true;

	for (auto& t : a->out(s.first))
	  {
	    bdd all = t.cond;
	    while (all != bddfalse)
	      {
		bdd one = bdd_satoneset(all, atomic_propositions, bddtrue);
		all -= one;

		stutter_state d(t.dst, one);

		auto r = ss2num.emplace(d, ss2num.size());
		unsigned dest = r.first->second;

		if (r.second)
		  {
		    todo.push_back(d);
		    unsigned u = res->new_state();
		    assert(u == dest);
		    (void)u;
		  }

345
346
		// Create the edge.
		res->new_edge(src, dest, one, t.acc);
347
348
349
350
351
352
353

		if (src == dest)
		  self_loop_needed = false;
	      }
	  }

	if (self_loop_needed && s.second != bddfalse)
354
	  res->new_edge(src, src, s.second, 0U);
355
      }
356
    res->merge_edges();
357
358
359
    return res;
  }

360
361
  twa_graph_ptr
  sl2(twa_graph_ptr&& a, bdd atomic_propositions)
362
363
  {
    if (atomic_propositions == bddfalse)
364
      atomic_propositions = a->ap_var();
365
    unsigned num_states = a->num_states();
366
    unsigned num_edges = a->num_edges();
Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
367
368
369
370
    std::vector<bdd> selfloops(num_states, bddfalse);
    std::map<std::pair<unsigned, int>, unsigned> newstates;
    // Record all the conditions for which we can selfloop on each
    // state.
371
    for (auto& t: a->edges())
Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
372
373
      if (t.src == t.dst)
	selfloops[t.src] |= t.cond;
374
    for (unsigned t = 1; t <= num_edges; ++t)
375
      {
376
377
	auto& td = a->edge_storage(t);
	if (a->is_dead_edge(td))
Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
378
379
380
381
382
383
384
385
	  continue;

	unsigned src = td.src;
	unsigned dst = td.dst;
	if (src != dst)
	  {
	    bdd all = td.cond;
	    // If there is a self-loop with the whole condition on
386
	    // either end of the edge, do not bother with it.
Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
387
388
389
	    if (bdd_implies(all, selfloops[src])
		|| bdd_implies(all, selfloops[dst]))
	      continue;
390
	    // Do not use td in the loop because the new_edge()
Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
391
392
393
394
395
396
397
398
399
400
401
402
403
404
	    // might invalidate it.
	    auto acc = td.acc;
	    while (all != bddfalse)
	      {
		bdd one = bdd_satoneset(all, atomic_propositions, bddtrue);
		all -= one;
		// Skip if there is a loop for this particular letter.
		if (bdd_implies(one, selfloops[src])
		    || bdd_implies(one, selfloops[dst]))
		  continue;
		auto p = newstates.emplace(std::make_pair(dst, one.id()), 0);
		if (p.second)
		  p.first->second = a->new_state();
		unsigned tmp = p.first->second; // intermediate state
405
406
407
408
		unsigned i = a->new_edge(src, tmp, one, acc);
		assert(i > num_edges);
		i = a->new_edge(tmp, tmp, one, 0U);
		assert(i > num_edges);
Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
409
		// No acceptance here to preserve the state-based property.
410
411
		i = a->new_edge(tmp, dst, one, 0U);
		assert(i > num_edges);
Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
412
413
414
		(void)i;
	      }
	  }
415
416
417
418
419
      }
    if (num_states != a->num_states())
      a->prop_keep({true,	// state_based
	            false,	// inherently_weak
	            false,	// deterministic
420
	            false,      // stutter inv.
421
	           });
422
    a->merge_edges();
423
424
425
    return a;
  }

426
427
  twa_graph_ptr
  sl2(const const_twa_graph_ptr& a, bdd atomic_propositions)
428
  {
429
    return sl2(make_twa_graph(a, twa::prop_set::all()),
430
431
432
433
	       atomic_propositions);
  }


434
435
  twa_graph_ptr
  closure(twa_graph_ptr&& a)
436
437
438
439
  {
    a->prop_keep({false,	// state_based
	          false,	// inherently_weak
	          false,	// deterministic
440
	          false,        // stutter inv.
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
	         });

    unsigned n = a->num_states();
    std::vector<unsigned> todo;
    std::vector<std::vector<unsigned> > dst2trans(n);

    for (unsigned state = 0; state < n; ++state)
      {
	auto trans = a->out(state);

	for (auto it = trans.begin(); it != trans.end(); ++it)
	  {
	    todo.push_back(it.trans());
	    dst2trans[it->dst].push_back(it.trans());
	  }

	while (!todo.empty())
	  {
459
	    auto t1 = a->edge_storage(todo.back());
460
461
462
463
464
465
466
467
468
469
470
	    todo.pop_back();

	    for (auto& t2 : a->out(t1.dst))
	      {
		bdd cond = t1.cond & t2.cond;
		if (cond != bddfalse)
		  {
                    bool need_new_trans = true;
		    acc_cond::mark_t acc = t1.acc | t2.acc;
                    for (auto& t: dst2trans[t2.dst])
                      {
471
                        auto& ts = a->edge_storage(t);
472
473
474
475
                        if (acc == ts.acc)
                          {
                            if (!bdd_implies(cond, ts.cond))
                              {
476
                                ts.cond |= cond;
477
478
479
480
481
                                if (std::find(todo.begin(), todo.end(), t)
                                    == todo.end())
                                  todo.push_back(t);
                              }
                            need_new_trans = false;
482
			    break;
483
                          }
484
485
486
487
488
489
490
491
492
493
494
495
496
			else if (cond == ts.cond)
			  {
			    acc |= ts.acc;
			    if (ts.acc != acc)
			      {
				ts.acc = acc;
				if (std::find(todo.begin(), todo.end(), t)
				    == todo.end())
				  todo.push_back(t);
			      }
                            need_new_trans = false;
			    break;
			  }
497
498
499
500
                      }
                    if (need_new_trans)
                      {
			// Load t2.dst first, because t2 can be
501
			// invalidated by new_edge().
502
			auto dst = t2.dst;
503
                        auto i = a->new_edge(state, dst, cond, acc);
504
505
506
507
508
509
510
511
512
513
514
515
                        dst2trans[dst].push_back(i);
                        todo.push_back(i);
                      }
		  }
	      }
	  }
        for (auto& it: dst2trans)
          it.clear();
      }
    return a;
  }

516
517
  twa_graph_ptr
  closure(const const_twa_graph_ptr& a)
518
  {
519
    return closure(make_twa_graph(a, {true, true, true, false}));
520
521
522
523
524
525
526
527
528
529
530
  }

  // The stutter check algorithm to use can be overridden via an
  // environment variable.
  static int default_stutter_check_algorithm()
  {
    static const char* stutter_check = getenv("SPOT_STUTTER_CHECK");
    if (stutter_check)
      {
	char* endptr;
	long res = strtol(stutter_check, &endptr, 10);
531
	if (*endptr || res < 0 || res > 9)
532
533
534
535
536
537
538
539
540
541
542
	  throw
	    std::runtime_error("invalid value for SPOT_STUTTER_CHECK.");
	return res;
      }
    else
      {
	return 8;     // The best variant, according to our benchmarks.
      }
  }

  bool
Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
543
  is_stutter_invariant(formula f)
544
  {
545
    if (f.is_ltl_formula() && f.is_syntactic_stutter_invariant())
546
547
548
549
      return true;

    int algo = default_stutter_check_algorithm();

550
551
    if (algo == 0 || algo == 9)
      // Etessami's check via syntactic transformation.
552
      {
553
	if (!f.is_ltl_formula())
554
555
556
	  throw std::runtime_error("Cannot use the syntactic "
				   "stutter-invariance check "
				   "for non-LTL formulas");
Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
557
	formula g = remove_x(f);
558
559
560
	bool res;
	if (algo == 0)		// Equivalence check
	  {
561
	    tl_simplifier ls;
562
563
564
565
	    res = ls.are_equivalent(f, g);
	  }
	else
	  {
Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
566
	    formula h = formula::Xor(f, g);
567
568
	    res = ltl_to_tgba_fm(h, make_bdd_dict())->is_empty();
	  }
569
570
571
572
573
574
	return res;
      }

    // Prepare for an automata-based check.
    translator trans;
    auto aut_f = trans.run(f);
Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
575
    auto aut_nf = trans.run(formula::Not(f));
576
577
578
579
580
    bdd aps = atomic_prop_collect_as_bdd(f, aut_f);
    return is_stutter_invariant(std::move(aut_f), std::move(aut_nf), aps, algo);
  }

  bool
581
582
  is_stutter_invariant(twa_graph_ptr&& aut_f,
                       twa_graph_ptr&& aut_nf, bdd aps, int algo)
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
  {
    if (algo == 0)
      algo = default_stutter_check_algorithm();

    switch (algo)
      {
      case 1: // sl(aut_f) x sl(aut_nf)
	return product(sl(std::move(aut_f), aps),
		       sl(std::move(aut_nf), aps))->is_empty();
      case 2: // sl(cl(aut_f)) x aut_nf
	return product(sl(closure(std::move(aut_f)), aps),
		       std::move(aut_nf))->is_empty();
      case 3: // (cl(sl(aut_f)) x aut_nf
	return product(closure(sl(std::move(aut_f), aps)),
		       std::move(aut_nf))->is_empty();
      case 4: // sl2(aut_f) x sl2(aut_nf)
	return product(sl2(std::move(aut_f), aps),
		       sl2(std::move(aut_nf), aps))->is_empty();
      case 5: // sl2(cl(aut_f)) x aut_nf
	return product(sl2(closure(std::move(aut_f)), aps),
		       std::move(aut_nf))->is_empty();
      case 6: // (cl(sl2(aut_f)) x aut_nf
	return product(closure(sl2(std::move(aut_f), aps)),
		       std::move(aut_nf))->is_empty();
      case 7: // on-the-fly sl(aut_f) x sl(aut_nf)
	return otf_product(make_tgbasl(aut_f, aps),
			   make_tgbasl(aut_nf, aps))->is_empty();
      case 8: // cl(aut_f) x cl(aut_nf)
	return product(closure(std::move(aut_f)),
		       closure(std::move(aut_nf)))->is_empty();
      default:
	throw std::runtime_error("invalid algorithm number for "
				 "is_stutter_invariant()");
	SPOT_UNREACHABLE();
      }
  }
619
620

  bool
Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
621
  check_stutter_invariance(const twa_graph_ptr& aut, formula f)
622
  {
623
    bool is_stut = aut->prop_stutter_invariant();
624
625
626
627
628
629
    if (is_stut)
      return is_stut;

    twa_graph_ptr neg = nullptr;
    if (f)
      {
Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
630
	neg = translator(aut->get_dict()).run(formula::Not(f));
631
632
633
634
635
636
      }
    else
      {
	// If the automaton is deterministic, we
	// know how to complement it.
	aut->prop_deterministic(is_deterministic(aut));
637
	if (!aut->prop_deterministic())
638
	  return false;
639
	neg = remove_fin(dtwa_complement(aut));
640
641
642
      }

    is_stut = is_stutter_invariant(make_twa_graph(aut, twa::prop_set::all()),
643
				   std::move(neg), aut->ap_var());
644
645
    aut->prop_stutter_invariant(is_stut);
    aut->prop_stutter_sensitive(!is_stut);
646
647
    return is_stut;
  }
648
}