stutter.cc 18.1 KB
Newer Older
1
// -*- coding: utf-8 -*-
2
3
// Copyright (C) 2014, 2015, 2016 Laboratoire de Recherche et
// Développement de l'Epita (LRDE).
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
//
// This file is part of Spot, a model checking library.
//
// Spot is free software; you can redistribute it and/or modify it
// under the terms of the GNU General Public License as published by
// the Free Software Foundation; either version 3 of the License, or
// (at your option) any later version.
//
// Spot is distributed in the hope that it will be useful, but WITHOUT
// ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
// or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public
// License for more details.
//
// You should have received a copy of the GNU General Public License
// along with this program.  If not, see <http://www.gnu.org/licenses/>.

20
21
22
23
24
25
26
27
28
29
30
31
#include <spot/twaalgos/stutter.hh>
#include <spot/twa/twa.hh>
#include <spot/misc/hash.hh>
#include <spot/misc/hashfunc.hh>
#include <spot/tl/apcollect.hh>
#include <spot/twaalgos/translate.hh>
#include <spot/tl/remove_x.hh>
#include <spot/twaalgos/product.hh>
#include <spot/twaalgos/ltl2tgba_fm.hh>
#include <spot/twaalgos/isdet.hh>
#include <spot/twaalgos/complement.hh>
#include <spot/twaalgos/remfin.hh>
32
#include <spot/twaalgos/postproc.hh>
33
34
#include <spot/twa/twaproduct.hh>
#include <spot/twa/bddprint.hh>
35
36
37
38
39
40
41
42
43
#include <deque>
#include <unordered_map>
#include <unordered_set>
#include <vector>

namespace spot
{
  namespace
  {
44
    class state_tgbasl final: public state
45
46
    {
    public:
47
      state_tgbasl(const state* s, bdd cond) : s_(s), cond_(cond)
48
49
50
51
52
53
54
55
56
57
      {
      }

      virtual
      ~state_tgbasl()
      {
        s_->destroy();
      }

      virtual int
58
      compare(const state* other) const override
59
60
61
62
63
64
65
66
67
68
69
      {
        const state_tgbasl* o =
          down_cast<const state_tgbasl*>(other);
        assert(o);
        int res = s_->compare(o->real_state());
        if (res != 0)
          return res;
        return cond_.id() - o->cond_.id();
      }

      virtual size_t
70
      hash() const override
71
72
73
74
75
      {
        return wang32_hash(s_->hash()) ^ wang32_hash(cond_.id());
      }

      virtual
76
      state_tgbasl* clone() const override
77
78
79
80
      {
        return new state_tgbasl(*this);
      }

81
      const state*
82
83
84
85
86
87
88
89
90
91
92
93
      real_state() const
      {
        return s_;
      }

      bdd
      cond() const
      {
        return cond_;
      }

    private:
94
      const state* s_;
95
96
97
      bdd cond_;
    };

98
    class twasl_succ_iterator final : public twa_succ_iterator
99
100
    {
    public:
101
      twasl_succ_iterator(twa_succ_iterator* it, const state_tgbasl* state,
102
                           bdd_dict_ptr d, bdd atomic_propositions)
103
104
105
106
107
        : it_(it), state_(state), aps_(atomic_propositions), d_(d)
      {
      }

      virtual
108
      ~twasl_succ_iterator()
109
110
111
112
113
114
      {
        delete it_;
      }

      // iteration

115
116
      virtual bool
      first() override
117
118
119
120
121
122
      {
        loop_ = false;
        done_ = false;
        need_loop_ = true;
        if (it_->first())
          {
123
            cond_ = it_->cond();
124
125
126
127
128
            next_edge();
          }
        return true;
      }

129
130
      virtual bool
      next() override
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
      {
        if (cond_ != bddfalse)
          {
            next_edge();
            return true;
          }
        if (!it_->next())
          {
            if (loop_ || !need_loop_)
              done_ = true;
            loop_ = true;
            return !done_;
          }
        else
          {
146
            cond_ = it_->cond();
147
148
149
150
151
            next_edge();
            return true;
          }
      }

152
153
      virtual bool
      done() const override
154
155
156
157
158
159
      {
        return it_->done() && done_;
      }

      // inspection

160
161
      virtual state_tgbasl*
      dst() const override
162
163
164
      {
        if (loop_)
          return new state_tgbasl(state_->real_state(), state_->cond());
165
        return new state_tgbasl(it_->dst(), one_);
166
167
      }

168
169
      virtual bdd
      cond() const override
170
171
172
173
174
175
      {
        if (loop_)
          return state_->cond();
        return one_;
      }

176
177
      virtual acc_cond::mark_t
      acc() const override
178
179
180
      {
        if (loop_)
          return 0U;
181
        return it_->acc();
182
183
184
185
186
187
188
189
190
      }

    private:
      void
      next_edge()
      {
        one_ = bdd_satoneset(cond_, aps_, bddtrue);
        cond_ -= one_;
        if (need_loop_ && (state_->cond() == one_)
191
            && (state_ == it_->dst()))
192
193
194
          need_loop_ = false;
      }

195
      twa_succ_iterator* it_;
196
197
198
199
200
201
202
203
204
205
206
      const state_tgbasl* state_;
      bdd cond_;
      bdd one_;
      bdd aps_;
      bdd_dict_ptr d_;
      bool loop_;
      bool need_loop_;
      bool done_;
    };


207
    class tgbasl final : public twa
208
209
    {
    public:
210
      tgbasl(const const_twa_ptr& a, bdd atomic_propositions)
211
        : twa(a->get_dict()), a_(a), aps_(atomic_propositions)
212
      {
213
214
215
        get_dict()->register_all_propositions_of(&a_, this);
        assert(num_sets() == 0);
        set_generalized_buchi(a_->num_sets());
216
217
      }

218
      virtual const state* get_init_state() const override
219
      {
220
        return new state_tgbasl(a_->get_init_state(), bddfalse);
221
222
      }

223
      virtual twa_succ_iterator* succ_iter(const state* state) const override
224
      {
225
226
227
228
        const state_tgbasl* s = down_cast<const state_tgbasl*>(state);
        assert(s);
        return new twasl_succ_iterator(a_->succ_iter(s->real_state()), s,
                                        a_->get_dict(), aps_);
229
230
231
232
      }

      virtual std::string format_state(const state* state) const override
      {
233
234
235
236
237
        const state_tgbasl* s = down_cast<const state_tgbasl*>(state);
        assert(s);
        return (a_->format_state(s->real_state())
                + ", "
                + bdd_format_formula(a_->get_dict(), s->cond()));
238
239
240
      }

    private:
241
      const_twa_ptr a_;
242
243
244
245
246
      bdd aps_;
    };

    typedef std::shared_ptr<tgbasl> tgbasl_ptr;

247
    inline tgbasl_ptr make_tgbasl(const const_twa_ptr& aut, bdd ap)
248
249
250
251
252
253
254
255
256
257
258
259
260
    {
      return std::make_shared<tgbasl>(aut, ap);
    }



    typedef std::pair<unsigned, bdd> stutter_state;

    struct stutter_state_hash
    {
      size_t
      operator()(const stutter_state& s) const
      {
261
        return wang32_hash(s.first) ^ wang32_hash(s.second.id());
262
263
264
265
266
      }
    };

    // Associate the stutter state to its number.
    typedef std::unordered_map<stutter_state, unsigned,
267
                               stutter_state_hash> ss2num_map;
268
269
270
271
272

    // Queue of state to be processed.
    typedef std::deque<stutter_state> queue_t;
  }

273
  twa_graph_ptr
274
  sl(const twa_graph_ptr& a)
275
  {
276
    return sl(a, a->ap_vars());
277
278
  }

279
  twa_graph_ptr
280
  sl2(const twa_graph_ptr& a)
281
  {
282
    return sl2(a, a->ap_vars());
283
284
  }

285
286
  twa_graph_ptr
  sl(const const_twa_graph_ptr& a, bdd atomic_propositions)
287
288
  {
    // The result automaton uses numbered states.
289
    twa_graph_ptr res = make_twa_graph(a->get_dict());
290
291
    // We use the same BDD variables as the input.
    res->copy_ap_of(a);
292
    res->copy_acceptance_of(a);
293
294
295
296
297
298
299
300
301
302
303
304
305
306
    // These maps make it possible to convert stutter_state to number
    // and vice-versa.
    ss2num_map ss2num;

    queue_t todo;

    unsigned s0 = a->get_init_state_number();
    stutter_state s(s0, bddfalse);
    ss2num[s] = 0;
    res->new_state();
    todo.push_back(s);

    while (!todo.empty())
      {
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
        s = todo.front();
        todo.pop_front();
        unsigned src = ss2num[s];

        bool self_loop_needed = true;

        for (auto& t : a->out(s.first))
          {
            bdd all = t.cond;
            while (all != bddfalse)
              {
                bdd one = bdd_satoneset(all, atomic_propositions, bddtrue);
                all -= one;

                stutter_state d(t.dst, one);

                auto r = ss2num.emplace(d, ss2num.size());
                unsigned dest = r.first->second;

                if (r.second)
                  {
                    todo.push_back(d);
                    unsigned u = res->new_state();
                    assert(u == dest);
                    (void)u;
                  }

                // Create the edge.
                res->new_edge(src, dest, one, t.acc);

                if (src == dest)
                  self_loop_needed = false;
              }
          }

        if (self_loop_needed && s.second != bddfalse)
          res->new_edge(src, src, s.second, 0U);
344
      }
345
    res->merge_edges();
346
347
348
    return res;
  }

349
350
  twa_graph_ptr
  sl2(twa_graph_ptr&& a, bdd atomic_propositions)
351
352
  {
    if (atomic_propositions == bddfalse)
353
      atomic_propositions = a->ap_vars();
354
    unsigned num_states = a->num_states();
355
    unsigned num_edges = a->num_edges();
Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
356
357
358
359
    std::vector<bdd> selfloops(num_states, bddfalse);
    std::map<std::pair<unsigned, int>, unsigned> newstates;
    // Record all the conditions for which we can selfloop on each
    // state.
360
    for (auto& t: a->edges())
Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
361
      if (t.src == t.dst)
362
        selfloops[t.src] |= t.cond;
363
    for (unsigned t = 1; t <= num_edges; ++t)
364
      {
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
        auto& td = a->edge_storage(t);
        if (a->is_dead_edge(td))
          continue;

        unsigned src = td.src;
        unsigned dst = td.dst;
        if (src != dst)
          {
            bdd all = td.cond;
            // If there is a self-loop with the whole condition on
            // either end of the edge, do not bother with it.
            if (bdd_implies(all, selfloops[src])
                || bdd_implies(all, selfloops[dst]))
              continue;
            // Do not use td in the loop because the new_edge()
            // might invalidate it.
            auto acc = td.acc;
            while (all != bddfalse)
              {
                bdd one = bdd_satoneset(all, atomic_propositions, bddtrue);
                all -= one;
                // Skip if there is a loop for this particular letter.
                if (bdd_implies(one, selfloops[src])
                    || bdd_implies(one, selfloops[dst]))
                  continue;
                auto p = newstates.emplace(std::make_pair(dst, one.id()), 0);
                if (p.second)
                  p.first->second = a->new_state();
                unsigned tmp = p.first->second; // intermediate state
                unsigned i = a->new_edge(src, tmp, one, acc);
                assert(i > num_edges);
                i = a->new_edge(tmp, tmp, one, 0U);
                assert(i > num_edges);
                // No acceptance here to preserve the state-based property.
                i = a->new_edge(tmp, dst, one, 0U);
                assert(i > num_edges);
                (void)i;
              }
          }
404
405
      }
    if (num_states != a->num_states())
406
407
408
      a->prop_keep({true,        // state_based
                    false,        // inherently_weak
                    false,        // deterministic
409
410
                    false,      // stutter inv.
                   });
411
    a->merge_edges();
412
413
414
    return a;
  }

415
416
  twa_graph_ptr
  sl2(const const_twa_graph_ptr& a, bdd atomic_propositions)
417
  {
418
    return sl2(make_twa_graph(a, twa::prop_set::all()),
419
               atomic_propositions);
420
421
422
  }


423
424
  twa_graph_ptr
  closure(twa_graph_ptr&& a)
425
  {
426
427
428
    a->prop_keep({false,        // state_based
                  false,        // inherently_weak
                  false,        // deterministic
429
430
                  false,        // stutter inv.
                 });
431
432
433
434
435
436
437

    unsigned n = a->num_states();
    std::vector<unsigned> todo;
    std::vector<std::vector<unsigned> > dst2trans(n);

    for (unsigned state = 0; state < n; ++state)
      {
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
        auto trans = a->out(state);

        for (auto it = trans.begin(); it != trans.end(); ++it)
          {
            todo.push_back(it.trans());
            dst2trans[it->dst].push_back(it.trans());
          }

        while (!todo.empty())
          {
            auto t1 = a->edge_storage(todo.back());
            todo.pop_back();

            for (auto& t2 : a->out(t1.dst))
              {
                bdd cond = t1.cond & t2.cond;
                if (cond != bddfalse)
                  {
456
                    bool need_new_trans = true;
457
                    acc_cond::mark_t acc = t1.acc | t2.acc;
458
459
                    for (auto& t: dst2trans[t2.dst])
                      {
460
                        auto& ts = a->edge_storage(t);
461
462
463
464
                        if (acc == ts.acc)
                          {
                            if (!bdd_implies(cond, ts.cond))
                              {
465
                                ts.cond |= cond;
466
467
468
469
470
                                if (std::find(todo.begin(), todo.end(), t)
                                    == todo.end())
                                  todo.push_back(t);
                              }
                            need_new_trans = false;
471
                            break;
472
                          }
473
474
475
476
477
478
479
480
481
482
                        else if (cond == ts.cond)
                          {
                            acc |= ts.acc;
                            if (ts.acc != acc)
                              {
                                ts.acc = acc;
                                if (std::find(todo.begin(), todo.end(), t)
                                    == todo.end())
                                  todo.push_back(t);
                              }
483
                            need_new_trans = false;
484
485
                            break;
                          }
486
487
488
                      }
                    if (need_new_trans)
                      {
489
490
491
                        // Load t2.dst first, because t2 can be
                        // invalidated by new_edge().
                        auto dst = t2.dst;
492
                        auto i = a->new_edge(state, dst, cond, acc);
493
494
495
                        dst2trans[dst].push_back(i);
                        todo.push_back(i);
                      }
496
497
498
                  }
              }
          }
499
500
501
502
503
504
        for (auto& it: dst2trans)
          it.clear();
      }
    return a;
  }

505
506
  twa_graph_ptr
  closure(const const_twa_graph_ptr& a)
507
  {
508
    return closure(make_twa_graph(a, {true, true, true, false}));
509
510
511
512
513
514
515
516
517
  }

  // The stutter check algorithm to use can be overridden via an
  // environment variable.
  static int default_stutter_check_algorithm()
  {
    static const char* stutter_check = getenv("SPOT_STUTTER_CHECK");
    if (stutter_check)
      {
518
519
520
521
522
523
        char* endptr;
        long res = strtol(stutter_check, &endptr, 10);
        if (*endptr || res < 0 || res > 9)
          throw
            std::runtime_error("invalid value for SPOT_STUTTER_CHECK.");
        return res;
524
525
526
      }
    else
      {
527
        return 8;     // The best variant, according to our benchmarks.
528
529
530
531
      }
  }

  bool
Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
532
  is_stutter_invariant(formula f)
533
  {
534
    if (f.is_ltl_formula() && f.is_syntactic_stutter_invariant())
535
536
537
538
      return true;

    int algo = default_stutter_check_algorithm();

539
540
    if (algo == 0 || algo == 9)
      // Etessami's check via syntactic transformation.
541
      {
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
        if (!f.is_ltl_formula())
          throw std::runtime_error("Cannot use the syntactic "
                                   "stutter-invariance check "
                                   "for non-LTL formulas");
        formula g = remove_x(f);
        bool res;
        if (algo == 0)                // Equivalence check
          {
            tl_simplifier ls;
            res = ls.are_equivalent(f, g);
          }
        else
          {
            formula h = formula::Xor(f, g);
            res = ltl_to_tgba_fm(h, make_bdd_dict())->is_empty();
          }
        return res;
559
560
561
562
563
      }

    // Prepare for an automata-based check.
    translator trans;
    auto aut_f = trans.run(f);
Alexandre Duret-Lutz's avatar
Alexandre Duret-Lutz committed
564
    auto aut_nf = trans.run(formula::Not(f));
565
566
567
568
569
    bdd aps = atomic_prop_collect_as_bdd(f, aut_f);
    return is_stutter_invariant(std::move(aut_f), std::move(aut_nf), aps, algo);
  }

  bool
570
571
  is_stutter_invariant(twa_graph_ptr&& aut_f,
                       twa_graph_ptr&& aut_nf, bdd aps, int algo)
572
573
574
575
576
577
578
  {
    if (algo == 0)
      algo = default_stutter_check_algorithm();

    switch (algo)
      {
      case 1: // sl(aut_f) x sl(aut_nf)
579
580
        return product(sl(std::move(aut_f), aps),
                       sl(std::move(aut_nf), aps))->is_empty();
581
      case 2: // sl(cl(aut_f)) x aut_nf
582
583
        return product(sl(closure(std::move(aut_f)), aps),
                       std::move(aut_nf))->is_empty();
584
      case 3: // (cl(sl(aut_f)) x aut_nf
585
586
        return product(closure(sl(std::move(aut_f), aps)),
                       std::move(aut_nf))->is_empty();
587
      case 4: // sl2(aut_f) x sl2(aut_nf)
588
589
        return product(sl2(std::move(aut_f), aps),
                       sl2(std::move(aut_nf), aps))->is_empty();
590
      case 5: // sl2(cl(aut_f)) x aut_nf
591
592
        return product(sl2(closure(std::move(aut_f)), aps),
                       std::move(aut_nf))->is_empty();
593
      case 6: // (cl(sl2(aut_f)) x aut_nf
594
595
        return product(closure(sl2(std::move(aut_f), aps)),
                       std::move(aut_nf))->is_empty();
596
      case 7: // on-the-fly sl(aut_f) x sl(aut_nf)
597
598
        return otf_product(make_tgbasl(aut_f, aps),
                           make_tgbasl(aut_nf, aps))->is_empty();
599
      case 8: // cl(aut_f) x cl(aut_nf)
600
601
        return product(closure(std::move(aut_f)),
                       closure(std::move(aut_nf)))->is_empty();
602
      default:
603
604
605
        throw std::runtime_error("invalid algorithm number for "
                                 "is_stutter_invariant()");
        SPOT_UNREACHABLE();
606
607
      }
  }
608

609
  trival
610
611
  check_stutter_invariance(const twa_graph_ptr& aut, formula f,
                           bool do_not_determinize)
612
  {
613
614
615
    trival is_stut = aut->prop_stutter_invariant();
    if (is_stut.is_known())
      return is_stut.is_true();
616
617
618
619

    twa_graph_ptr neg = nullptr;
    if (f)
      {
620
        neg = translator(aut->get_dict()).run(formula::Not(f));
621
622
623
      }
    else
      {
624
625
626
627
628
629
630
631
632
633
634
635
        twa_graph_ptr tmp = aut;
        if (!is_deterministic(aut))
          {
            if (do_not_determinize)
              return trival::maybe();
            spot::postprocessor p;
            p.set_type(spot::postprocessor::Generic);
            p.set_pref(spot::postprocessor::Deterministic);
            p.set_level(spot::postprocessor::Low);
            tmp = p.run(aut);
          }
        neg = dtwa_complement(tmp);
636
637
638
      }

    is_stut = is_stutter_invariant(make_twa_graph(aut, twa::prop_set::all()),
639
                                   std::move(neg), aut->ap_vars());
640
    aut->prop_stutter_invariant(is_stut);
641
642
    return is_stut;
  }
643
}