Commit c968e7b8 authored by Alexandre Duret-Lutz's avatar Alexandre Duret-Lutz

ltl2tgba_fm: fix setting of unambiguous property

Report from Joachim Klein.

* spot/twaalgos/ltl2tgba_fm.cc: Set the property, do not read it.
* tests/core/unambig.test: Add a test.
* NEWS: Mention the bug.
parent a3c26916
...@@ -23,6 +23,11 @@ New in spot 1.99.7a (not yet released) ...@@ -23,6 +23,11 @@ New in spot 1.99.7a (not yet released)
pointers) for some concepts used in Spot. pointers) for some concepts used in Spot.
See https://spot.lrde.epita.fr/concepts.html See https://spot.lrde.epita.fr/concepts.html
Bugs:
* Using ltl2tgba -U would fail to output the unambiguous property
(regression introduced in 1.99.7)
New in spot 1.99.7 (2016-01-15) New in spot 1.99.7 (2016-01-15)
Command-line tools: Command-line tools:
......
...@@ -2193,7 +2193,7 @@ namespace spot ...@@ -2193,7 +2193,7 @@ namespace spot
} }
if (unambiguous) if (unambiguous)
a->prop_unambiguous(); a->prop_unambiguous(true);
// Set the following to true to preserve state names. // Set the following to true to preserve state names.
a->release_formula_namer(namer, false); a->release_formula_namer(namer, false);
......
#!/bin/sh #!/bin/sh
# -*- coding: utf-8 -*- # -*- coding: utf-8 -*-
# Copyright (C) 2013, 2015 Laboratoire de Recherche et Developpement # Copyright (C) 2013, 2015, 2016 Laboratoire de Recherche et
# de l'Epita # Developpement de l'Epita
# #
# This file is part of Spot, a model checking library. # This file is part of Spot, a model checking library.
# #
...@@ -187,6 +187,12 @@ State: 2 ...@@ -187,6 +187,12 @@ State: 2
--END-- --END--
EOF EOF
# Thus should be marked as unambiguous. Report from Joachim Klein.
ltl2tgba --lbt-input -B -U -x wdba-minimize=0 "U p0 & p1 X ! p0" |
grep 'properties:.*unambiguous'
# Make sure we preserve the "unambiguous" property if it is given. # Make sure we preserve the "unambiguous" property if it is given.
run 0 $autfilt -H --is-unambiguous input >output run 0 $autfilt -H --is-unambiguous input >output
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment