1. 13 Jul, 2020 12 commits
    • Alexandre Duret-Lutz's avatar
      ltlsynt: add --algo=ps · 16540869
      Alexandre Duret-Lutz authored
      * bin/ltlsynt.cc: Implement this.
      * tests/core/ltlsynt.test: Add a test case.
      * NEWS: Mention it.
      16540869
    • Alexandre Duret-Lutz's avatar
      simplify_acc: perform unit-propagation earlier · b434ac7f
      Alexandre Duret-Lutz authored
      Closes #405.   This shows no difference on the test suite,
      but that is thanks to the previous patch: without it, an
      example in automata.ipynb would have an extra edge.
      
      * spot/twaalgos/cleanacc.cc (simplify_acceptance): Call
      unit_propagation() before simplify_complementary_marks_here() and
      fuse_marks_here(), because that is simpler to perform.
      b434ac7f
    • Alexandre Duret-Lutz's avatar
      remfin: do not clone transitions that are accepting in main · b762f542
      Alexandre Duret-Lutz authored
      * spot/twaalgos/remfin.cc (default_strategy): Detect transitions
      from the main copy that are completely accepting and that do not
      need to be repeated in the clones.
      * tests/python/remfin.py: Add a test case.
      * tests/core/ltl2dstar4.test: Improve expected results.
      * NEWS: Mention the change.
      b762f542
    • Alexandre Duret-Lutz's avatar
      improve fuse_marks_here by detecting more patterns · c005041e
      Alexandre Duret-Lutz authored
      This remove some restrictions that prevented fuse_marks_here from
      simplifying certain patterns, as noted in the first comment of
      issue #405.
      
      * spot/twaalgos/cleanacc.cc (find_interm_rec, find_fusable): Remove
      some unnecessary restrictions to singleton marks, and replace the hack
      put one non-singleton mark at the beginning of the singleton list by a
      sort.
      * tests/python/simplacc.py: Add two test cases.
      * tests/python/automata.ipynb, tests/core/remfin.test: Improve
      expected results.
      * NEWS: Mention the bug.
      c005041e
    • Alexandre Duret-Lutz's avatar
      fixpool: allocate a new chunk on creation · ce695e67
      Alexandre Duret-Lutz authored
      Allocate the first chunk when the fixpool is created.  This avoid a
      undefined behavior reported in issue #413 without requiring an extra
      comparison in allocate().
      
      * spot/misc/fixpool.hh, spot/misc/fixpool.cc (new_chunk_): New method
      extracted from allocate().  Use it in the constructor as well.
      * NEWS: Mention the bug.
      ce695e67
    • Alexandre Duret-Lutz's avatar
      postproc: option to wdba-minimize only when sure · 64aee87d
      Alexandre Duret-Lutz authored
      Fixes #15.
      
      * spot/twaalgos/minimize.hh, spot/twaalgos/minimize.cc
      (minimize_obligation_garanteed_to_work): New function.
      * spot/twaalgos/postproc.hh, spot/twaalgos/postproc.cc: Use it if
      wdba-minimize=1.  Handle new default for wdba-minimize.
      * NEWS, bin/spot-x.cc: Document those changes.
      * tests/core/ltl2tgba2.test: Add some test cases.
      * tests/core/genltl.test: Improve expected results.
      64aee87d
    • Alexandre Duret-Lutz's avatar
    • Alexandre Duret-Lutz's avatar
      stats: speed up the computation of transitions · d25fcb23
      Alexandre Duret-Lutz authored
      Juraj Major reported a case with 32 APs where ltlcross would take
      forever to gather statistics.  It turns out that for each edge,
      twa_sub_statistics was enumerating all compatible assignments of 32
      APs.  This uses bdd_satcountset() instead, and also store the result
      in a long long to avoid overflows.
      
      * spot/twaalgos/stats.cc (twa_sub_statistics): Improve the code for
      counting transitions.
      * bin/common_aoutput.hh, bin/ltlcross.cc, spot/twaalgos/stats.hh:
      Store transition counts are long long.
      * tests/core/readsave.test: Add test case.
      * NEWS: Mention the bug.
      d25fcb23
    • Alexandre Duret-Lutz's avatar
      [buddy] avoid cache errors in bdd_satcount() and friends · 4608d9a5
      Alexandre Duret-Lutz authored
      * src/bddop.c (bdd_satcount, bdd_satcountln): If the number of
      declared variables changed since we last used it, reset misccache.
      Otherwise, bdd_satcount() and friends might return incorrect results
      after the number of variable is changed.  These is needed for the next
      patch in Spot to pass all tests.
      (misccache_varnum): New global variable to track that.
      (bdd_satcountset): Make sure that bdd_satcountset(bddtrue, bddtrue)
      return 1.0 and not 0.0.
      4608d9a5
    • Alexandre Duret-Lutz's avatar
      ltlsynt: make sure the previous Xor optimization actually works · fc1c17b9
      Alexandre Duret-Lutz authored
      * spot/tl/simplify.hh, spot/tl/simplify.cc,
      spot/twaalgos/translate.cc: Update the tl_simplification
      options after all preferences have been given.
      * bin/ltlsynt.cc: Display the size of the translation output.
      * tests/core/ltlsynt.test: Add test case.
      fc1c17b9
    • Alexandre Duret-Lutz's avatar
      translate: improve handling of Xor and Equiv at top-level for -G -D · 6ec61504
      Alexandre Duret-Lutz authored
      * spot/tl/formula.hh: Add variant of formula::is that support 4
      arguments.
      * spot/tl/simplify.hh, spot/tl/simplify.cc: Add option keep_top_xor
      to preserve Xor and Equiv at the top-level.
      * spot/twaalgos/translate.cc: Adjust ltl-split to deal with Xor and
      Equiv for the -D -G case.
      * NEWS: Mention that.
      * tests/core/ltl2tgba2.test: Add test case.
      * tests/python/simstate.py: Adjust expected result.
      6ec61504
    • Alexandre Duret-Lutz's avatar
      product: add product_xor() and product_xnor() · 822b7491
      Alexandre Duret-Lutz authored
      * spot/twaalgos/product.cc, spot/twaalgos/product.hh: Add those
      functions.
      * tests/python/_product_weak.ipynb, tests/python/except.py: Test them.
      * NEWS: Mention them.
      822b7491
  2. 30 Apr, 2020 5 commits
  3. 29 Apr, 2020 2 commits
    • Alexandre Duret-Lutz's avatar
      dot: fix #393 · a7051b32
      Alexandre Duret-Lutz authored
      * spot/twaalgos/dot.cc: Add support for option 'E', and default to
      rectangle nodes for large labels.
      * bin/common_aoutput.cc, NEWS: Document it.
      * tests/core/alternating.test, tests/core/dstar.test,
      tests/core/readsave.test, tests/core/sccdot.test,
      tests/core/tgbagraph.test, tests/python/_product_weak.ipynb,
      tests/python/alternation.ipynb, tests/python/atva16-fig2b.ipynb,
      tests/python/automata.ipynb, tests/python/decompose.ipynb,
      tests/python/gen.ipynb, tests/python/highlighting.ipynb,
      tests/python/ltsmin-dve.ipynb, tests/python/ltsmin-pml.ipynb,
      tests/python/parity.ipynb, tests/python/pdegen.py,
      tests/python/satmin.ipynb, tests/python/stutter-inv.ipynb: Adjust all
      test cases.
      a7051b32
    • Alexandre Duret-Lutz's avatar
      dot: fix #392 · 3ea63e9a
      Alexandre Duret-Lutz authored
      * spot/twaalgos/dot.cc: Add tooltips to "..." states and edges.
      * tests/core/readsave.test: Test this.
      * tests/python/highlighting.ipynb: Adjust.
      3ea63e9a
  4. 25 Apr, 2020 2 commits
    • Alexandre Duret-Lutz's avatar
      postproc: fix issue #402 · 67060420
      Alexandre Duret-Lutz authored
      * spot/twaalgos/postproc.cc, spot/twaalgos/postproc.hh,
      spot/twaalgos/translate.cc: Introduce a gen-reduce-parity option and
      use it on sub-automata built by ltl-split.
      * bin/spot-x.cc: Document it.
      * tests/core/ltl2tgba2.test: Add test case reported by Juraj Major.
      67060420
    • Alexandre Duret-Lutz's avatar
      ltlsynt: fix lar.old implementation · fe340ae8
      Alexandre Duret-Lutz authored
      * bin/ltlsynt.cc: Make sure to_parity_old() receive a deterministic
      automaton, for correctness.   Also call reduce_parity() afterward,
      to match what was done in 2.8.7.
      * tests/core/ltlsynt.test: Include lar.old in the comparison of all
      results to make sure it give the same result as the other 3
      algorithms.
      fe340ae8
  5. 20 Apr, 2020 1 commit
  6. 19 Apr, 2020 2 commits
    • Alexandre Duret-Lutz's avatar
      192ca910
    • Alexandre Duret-Lutz's avatar
      avoid mark_t::count() when possible · cc12d514
      Alexandre Duret-Lutz authored
      count() may be implemented using a loop, so using it touch
      check count() == 1 or count() > 1 is not advisable.
      
      * spot/twa/acc.hh (mark_t::is_singleton, mark_t::has_many): Introduce
      these two methods to replace count()==1 and count()>1
      * spot/twa/acc.cc, spot/twaalgos/cleanacc.cc,
      spot/twaalgos/determinize.cc, spot/twaalgos/dtwasat.cc,
      spot/twaalgos/iscolored.cc, spot/twaalgos/remfin.cc,
      spot/twaalgos/toparity.cc: Adjust usage.
      cc12d514
  7. 18 Apr, 2020 4 commits
  8. 17 Apr, 2020 7 commits
    • Alexandre Duret-Lutz's avatar
      to_parity: only call reduce_parity() when prefix_parity is enabled · fd0d752b
      Alexandre Duret-Lutz authored
      Calling reduce_parity() in to_parity() is confusing, because then
      running to_parity() on one SCC does not necessarily produce the same
      output as running to_parity() on the entire automaton.  However it is
      necessary for the implementation of parity_prefix.  As a compromise,
      disable reduce_parity() when parity_prefix is disabled, this way we
      can use that to demonstrate how the algorithm works.
      
      * spot/twaalgos/toparity.hh, spot/twaalgos/toparity.cc: Do not
      call reduce_parity() when parity_prefix is disabled.
      * tests/python/toparity.py: Adjust.
      fd0d752b
    • Alexandre Duret-Lutz's avatar
      simplify_acc: loop over the simplifications · 102ef043
      Alexandre Duret-Lutz authored
      * spot/twaalgos/cleanacc.cc (simplify_acceptance_here): Run the
      simplifications in a loop until the condition does not change anymore.
      * tests/python/simplacc.py, tests/core/accsimpl.test,
      tests/core/remfin.test, tests/python/merge.py,
      tests/python/simplacc.py, tests/python/toparity.py: Update expected
      results.
      * tests/python/automata.ipynb: Update the failing example to a more
      interesting one, matching the one in doc/org/autfilt.org.
      102ef043
    • Alexandre Duret-Lutz's avatar
      simplify_acc: fix an infinite loop · b62e1bb1
      Alexandre Duret-Lutz authored
      * spot/twaalgos/cleanacc.cc (fuse_mark_here): Fix incorrect cancelling
      of n-ary subterms, causing an invalid acceptance condition, and then
      an infinite loop.
      * tests/python/simplacc.py: Add test case.
      b62e1bb1
    • Florian Renkin's avatar
      to_parity: Correct the expected number of states · 68012e6a
      Florian Renkin authored
      * tests/python/toparity.py: here.
      68012e6a
    • Florian Renkin's avatar
      to_parity: Add an option to force degeneralization · 685d6d8b
      Florian Renkin authored
      * spot/twaalgos/toparity.cc, spot/twaalgos/toparity.hh:
      Don't try to run the algorithm without degeneralization
      with the option force_degen.
      685d6d8b
    • Florian Renkin's avatar
      to_parity: Remove merge_states · 527b62c5
      Florian Renkin authored
      * spot/twaalgos/toparity.cc: Remove merge_states.
      * tests/python/automata.ipynb, tests/python/toparity.py: Update tests.
      527b62c5
    • Florian Renkin's avatar
      unit_propagation: Add a test with multiple unit clauses · 142f1afa
      Florian Renkin authored
      * tests/core/acc.cc, tests/core/acc.test: here.
      142f1afa
  9. 16 Apr, 2020 5 commits
    • Florian Renkin's avatar
      unit_propagation: Correct a problem with multiple marks · 927ea704
      Florian Renkin authored
      * spot/twa/acc.cc: Don't create a conjunction of Inf with multiple marks
      in unit_propagation.
      927ea704
    • Florian Renkin's avatar
      to_parity: Use merge_states · 8c480039
      Florian Renkin authored
      * spot/twaalgos/toparity.cc: Use merge_states at the end
      of to_parity.
      * tests/python/toparity.py: Update tests.
      8c480039
    • Alexandre Duret-Lutz's avatar
      toparity: false transitions are not a problem anymore · 875846f5
      Alexandre Duret-Lutz authored
      * spot/twaalgos/toparity.cc: Do not remove false transitions.
      * tests/python/toparity.py: Add a test case with false transitions.
      875846f5
    • Alexandre Duret-Lutz's avatar
      update gnulib to 47bf2cf3184027c1eb9c1dfeea5c5b8b2d69710d · 1e864632
      Alexandre Duret-Lutz authored
      * lib/dosname.h, lib/glthread/lock.c, lib/glthread/lock.h,
      lib/glthread/threadlib.c, lib/windows-mutex.c, lib/windows-mutex.h,
      lib/windows-once.c, lib/windows-once.h, lib/windows-recmutex.c,
      lib/windows-recmutex.h, lib/windows-rwlock.c, lib/windows-rwlock.h,
      m4/host-cpu-c-abi.m4, m4/lib-ld.m4, m4/lib-link.m4, m4/lib-prefix.m4,
      m4/lock.m4, m4/longlong.m4, m4/pthread_rwlock_rdlock.m4,
      tools/config.rpath: Delete.
      * lib/alloca.in.h, lib/argmatch.c, lib/argmatch.h, lib/arg-nonnull.h,
      lib/argp-ba.c, lib/argp-eexst.c, lib/argp-fmtstream.c,
      lib/argp-fmtstream.h, lib/argp-fs-xinl.c, lib/argp.h, lib/argp-help.c,
      lib/argp-namefrob.h, lib/argp-parse.c, lib/argp-pin.c, lib/argp-pv.c,
      lib/argp-pvh.c, lib/argp-xinl.c, lib/asnprintf.c, lib/basename-lgpl.c,
      lib/c-ctype.h, lib/c++defs.h, lib/cdefs.h, lib/closeout.c,
      lib/closeout.h, lib/close-stream.c, lib/c-strcasecmp.c,
      lib/c-strcaseeq.h, lib/c-strcase.h, lib/c-strncasecmp.c,
      lib/dirname.h, lib/dirname-lgpl.c, lib/errno.in.h, lib/error.c,
      lib/error.h, lib/exitfail.c, lib/exitfail.h, lib/fcntl.in.h,
      lib/filename.h, lib/float.c, lib/float+.h, lib/float.in.h,
      lib/fpending.c, lib/fpending.h, lib/getopt1.c, lib/getopt.c,
      lib/getopt-cdefs.in.h, lib/getopt-core.h, lib/getopt-ext.h,
      lib/getopt.in.h, lib/getopt_int.h, lib/getopt-pfx-core.h,
      lib/getopt-pfx-ext.h, lib/getprogname.c, lib/getprogname.h,
      lib/gettext.h, lib/gettimeofday.c, lib/hard-locale.c,
      lib/hard-locale.h, lib/intprops.h, lib/isatty.c, lib/itold.c,
      lib/libc-config.h, lib/limits.in.h, lib/localcharset.c,
      lib/localcharset.h, lib/localtime-buffer.c, lib/localtime-buffer.h,
      lib/lstat.c, lib/Makefile.am, lib/malloca.c, lib/malloca.h,
      lib/malloc.c, lib/mbrtowc.c, lib/mbsinit.c, lib/memchr.c,
      lib/memchr.valgrind, lib/mempcpy.c, lib/minmax.h, lib/mkdir.c,
      lib/mkstemp.c, lib/mkstemps.c, lib/msvc-inval.c, lib/msvc-inval.h,
      lib/msvc-nothrow.c, lib/msvc-nothrow.h, lib/_Noreturn.h,
      lib/pathmax.h, lib/printf-args.c, lib/printf-args.h,
      lib/printf-parse.c, lib/printf-parse.h, lib/progname.c,
      lib/progname.h, lib/quotearg.c, lib/quotearg.h, lib/quote.h,
      lib/rawmemchr.c, lib/rawmemchr.valgrind, lib/secure_getenv.c,
      lib/size_max.h, lib/sleep.c, lib/stat.c, lib/stat-time.h,
      lib/stat-w32.c, lib/stat-w32.h, lib/stdalign.in.h, lib/stdbool.in.h,
      lib/stddef.in.h, lib/stdint.in.h, lib/stdio-impl.h, lib/stdio.in.h,
      lib/stdlib.in.h, lib/stpcpy.c, lib/strcasecmp.c, lib/strchrnul.c,
      lib/strchrnul.valgrind, lib/streq.h, lib/strerror.c,
      lib/strerror-override.c, lib/strerror-override.h, lib/string.in.h,
      lib/strings.in.h, lib/stripslash.c, lib/strncasecmp.c, lib/strndup.c,
      lib/strnlen.c, lib/strverscmp.c, lib/sysexits.in.h, lib/sys_stat.in.h,
      lib/sys_time.in.h, lib/sys_types.in.h, lib/sys_wait.in.h,
      lib/tempname.c, lib/tempname.h, lib/time.in.h, lib/unistd.in.h,
      lib/vasnprintf.c, lib/vasnprintf.h, lib/verify.h, lib/vsnprintf.c,
      lib/warn-on-use.h, lib/wchar.in.h, lib/wctype.in.h,
      lib/windows-initguard.h, lib/xalloc-die.c, lib/xalloc.h,
      lib/xalloc-oversized.h, lib/xmalloc.c, lib/xsize.h, m4/00gnulib.m4,
      m4/absolute-header.m4, m4/alloca.m4, m4/argp.m4, m4/codeset.m4,
      m4/dirname.m4, m4/double-slash-root.m4, m4/eealloc.m4, m4/errno_h.m4,
      m4/error.m4, m4/exponentd.m4, m4/extensions.m4, m4/extern-inline.m4,
      m4/fcntl_h.m4, m4/fcntl-o.m4, m4/float_h.m4, m4/fpending.m4,
      m4/getopt.m4, m4/getprogname.m4, m4/gettimeofday.m4,
      m4/gnulib-cache.m4, m4/gnulib-common.m4, m4/gnulib-comp.m4,
      m4/gnulib-tool.m4, m4/include_next.m4, m4/__inline.m4, m4/intmax_t.m4,
      m4/inttypes_h.m4, m4/isatty.m4, m4/largefile.m4, m4/limits-h.m4,
      m4/localcharset.m4, m4/locale-fr.m4, m4/locale-ja.m4, m4/locale-zh.m4,
      m4/localtime-buffer.m4, m4/lstat.m4, m4/malloca.m4, m4/malloc.m4,
      m4/math_h.m4, m4/mbrtowc.m4, m4/mbsinit.m4, m4/mbstate_t.m4,
      m4/memchr.m4, m4/mempcpy.m4, m4/minmax.m4, m4/mkdir.m4, m4/mkstemp.m4,
      m4/mkstemps.m4, m4/mmap-anon.m4, m4/msvc-inval.m4, m4/msvc-nothrow.m4,
      m4/multiarch.m4, m4/nocrash.m4, m4/off_t.m4, m4/pathmax.m4,
      m4/printf.m4, m4/quotearg.m4, m4/quote.m4, m4/rawmemchr.m4,
      m4/secure_getenv.m4, m4/size_max.m4, m4/sleep.m4, m4/ssize_t.m4,
      m4/stat.m4, m4/stat-time.m4, m4/stdalign.m4, m4/stdbool.m4,
      m4/stddef_h.m4, m4/std-gnu11.m4, m4/stdint_h.m4, m4/stdint.m4,
      m4/stdio_h.m4, m4/stdlib_h.m4, m4/stpcpy.m4, m4/strcase.m4,
      m4/strchrnul.m4, m4/strerror.m4, m4/string_h.m4, m4/strings_h.m4,
      m4/strndup.m4, m4/strnlen.m4, m4/strverscmp.m4, m4/sysexits.m4,
      m4/sys_socket_h.m4, m4/sys_stat_h.m4, m4/sys_time_h.m4,
      m4/sys_types_h.m4, m4/sys_wait_h.m4, m4/tempname.m4, m4/threadlib.m4,
      m4/time_h.m4, m4/unistd_h.m4, m4/vasnprintf.m4, m4/vsnprintf.m4,
      m4/warn-on-use.m4, m4/wchar_h.m4, m4/wchar_t.m4, m4/wctype_h.m4,
      m4/wint_t.m4, m4/xalloc.m4, m4/xsize.m4: Update.
      * lib/inttypes.in.h, lib/lc-charset-dispatch.c,
      lib/lc-charset-dispatch.h, lib/locale.in.h, lib/mbrtowc-impl.h,
      lib/mbrtowc-impl-utf8.h, lib/mbtowc-lock.c, lib/mbtowc-lock.h,
      lib/setlocale-lock.c, lib/setlocale_null.c, lib/setlocale_null.h,
      m4/inttypes.m4, m4/locale_h.m4, m4/setlocale_null.m4,
      m4/visibility.m4, m4/zzgnulib.m4: New files.
      1e864632
    • Alexandre Duret-Lutz's avatar
      acc: make sure unit_propagate preserve the number of sets · fe642bc9
      Alexandre Duret-Lutz authored
      * spot/twa/acc.hh: Here.
      * tests/core/accsimpl.test, tests/core/ltl2tgba2.test: Add test cases.
      fe642bc9