1. 03 Jun, 2017 1 commit
    • Alexandre Duret-Lutz's avatar
      simulation: do not depend on bdd numbers for ordering classes · ae0e84ac
      Alexandre Duret-Lutz authored
      Fixes #262 again.  Reported by Maximilien Colange.
      
      * spot/twaalgos/simulation.cc: Use state numbers to order classes, not
      their signatures.  The problem was that even if two simulation of the
      same automaton assign the same signature, the BDD identifier used for
      that signature might be different, and therefore the ordering obtained
      by using BDDs as keys in a map can be different.  A side-effect of
      this change is that the order of states in automata produced by
      simulation-based reduction may change; many tests had to be updated.
      * tests/core/ltl2tgba.test: Add a new test case based on Maximilien's
      report.
      * tests/core/complement.test, tests/core/det.test,
      tests/core/parseaut.test, tests/core/prodor.test,
      tests/python/atva16-fig2a.ipynb, tests/python/automata.ipynb,
      tests/python/decompose.ipynb, tests/python/highlighting.ipynb,
      tests/python/piperead.ipynb, tests/python/testingaut.ipynb,
      tests/python/word.ipynb: Update test cases for new order of states.
      ae0e84ac
  2. 02 Jun, 2017 1 commit
    • Alexandre Duret-Lutz's avatar
      dot: fix printing of alternating automata · 7b6cfd44
      Alexandre Duret-Lutz authored
      Related to #208.
      
      * spot/twaalgos/dot.cc: Fix missing definitions of universal nodes,
      and inclusion of universal nodes inside of SCC when none of the
      destination comes back to the SCC.
      * tests/python/_altscc.ipynb: Adjust and add more test cases.
      * tests/core/alternating.test, tests/core/neverclaimread.test,
      tests/core/readsave.test, tests/core/sccdot.test,
      tests/python/decompose.ipynb: Adjust test cases.
      * NEWS: Mention the bug.
      7b6cfd44
  3. 10 May, 2017 1 commit
    • Alexandre Duret-Lutz's avatar
      ltl2tgba: clear simplification cache between translations · aa404823
      Alexandre Duret-Lutz authored
      The cache used in formula simplification will keep atomic propositions
      defined between several translations, and may impact variable order.
      Reported by Maximilien Colange.
      
      * spot/tl/simplify.hh, spot/tl/simplify.cc,
      spot/twaalgos/translate.cc, spot/twaalgos/translate.hh (clear_cache):
      New method.
      * bin/ltl2tgba.cc, bin/ltl2tgta.cc: Call it.
      * spot/twaalgos/stats.cc: Do not keep a point to the formula after
      printing statistics.
      * tests/core/ltl2tgba.test: Add a test case.
      * tests/core/readsave.test: Adjust one formula.
      * NEWS: Mention the issue.
      aa404823
  4. 19 Apr, 2017 1 commit
    • Alexandre Duret-Lutz's avatar
      sbacc: fix a serious bug · f02ca87f
      Alexandre Duret-Lutz authored
      Reported by Thibaud Michaud
      
      * spot/twaalgos/sbacc.cc: Do not label rejecting SCCs with the empty
      mark, as it might be accepting.
      * tests/core/sbacc.test: Add test cases.
      * NEWS: Mention the bug.
      f02ca87f
  5. 08 Apr, 2017 1 commit
  6. 07 Apr, 2017 1 commit
    • Alexandre Duret-Lutz's avatar
      remfin: fix a corner case for rabin_to_buchi_maybe · 1daffe12
      Alexandre Duret-Lutz authored
      when fin_alone sets where presents (i.e., not really Rabin condition),
      the rabin_to_buchi_maybe() could fail to notice DBA-typeness.
      
      * spot/twaalgos/remfin.cc: Don't set scc_ba_type to false when
      fin_alone is present.
      * tests/core/remfin.test: Add a test case.
      1daffe12
  7. 31 Mar, 2017 1 commit
    • Alexandre Duret-Lutz's avatar
      various typos · 1ed6e518
      Alexandre Duret-Lutz authored
      * bench/dtgbasat/gen.py, spot/twaalgos/complement.hh: Fix
      looser->loser and lossing->losing.
      * tests/sanity/style.test: Catch 'an uni[^n]'.
      * spot/ta/ta.hh, spot/taalgos/tgba2ta.cc, spot/taalgos/tgba2ta.hh,
      spot/twa/twagraph.cc, spot/twaalgos/complement.hh,
      spot/twaalgos/sccinfo.cc: Fix various occurences of this pattern.
      1ed6e518
  8. 28 Mar, 2017 1 commit
  9. 10 Mar, 2017 1 commit
    • Alexandre Duret-Lutz's avatar
      emptiness checks: replace assert-preconditions by exceptions · d6d987bd
      Alexandre Duret-Lutz authored
      * spot/twaalgos/couvreurnew.cc, spot/twaalgos/gv04.cc,
      spot/twaalgos/magic.cc, spot/twaalgos/se05.cc, spot/twaalgos/tau03.cc,
      spot/twaalgos/tau03opt.cc: Throw if precondition on acceptance
      condition is not satisfied.
      * tests/python/misc-ec.py: New file.
      * tests/Makefile.am: Add it.
      * NEWS: Mention the change.
      d6d987bd
  10. 08 Mar, 2017 1 commit
  11. 07 Mar, 2017 1 commit
  12. 03 Mar, 2017 3 commits
    • Alexandre Duret-Lutz's avatar
      monitor: fix -MD/-M difference in property output · 0621e0e9
      Alexandre Duret-Lutz authored
      Fixes #241.
      
      * spot/twaalgos/postproc.cc: Use the deterministic monitor if it
      has as many states as the non-deterministic one.
      * spot/twaalgos/minimize.cc (minimize_monitor): Quickly check
      for terminal automata.
      * spot/twaalgos/stripacc.cc: Set the weak property.
      * spot/twaalgos/stripacc.hh: Improve documentation.
      * tests/core/monitor.test, tests/core/sbacc.test: Update.
      * NEWS: Mention the issue.
      0621e0e9
    • Alexandre Duret-Lutz's avatar
      postproc: fix monitor code · 9defdad2
      Alexandre Duret-Lutz authored
      Fixes #240.
      
      * spot/twaalgos/postproc.cc: Do not call do_simul on the output of
      minimize_monitor(), and do not skip complete() when PREF_==Any.
      * tests/core/monitor.test: Add a test case.
      * NEWS: Mention the bug.
      * doc/org/ltl2tgba.org: Document complete monitors.
      9defdad2
    • Alexandre Duret-Lutz's avatar
      sbacc: fix a typo and remove some useless code · 57ea6d96
      Alexandre Duret-Lutz authored
      * spot/twaalgos/sbacc.cc: Do not assign to one_in twice, and
      fix the value of init_acc.
      * tests/core/sbacc.test: Add a test case.
      * NEWS: Mention the bug.
      57ea6d96
  13. 16 Feb, 2017 2 commits
    • Arthur Remaud's avatar
      autfilt: Better display of cluster when universal edge loops in it · f7bbfd28
      Arthur Remaud authored
      Fixes #208
      
      * NEWS: Informations about the modifications
      * spot/twaalgos/dot.cc (print): Gestion of cluster for
      universal transitions
      * tests/core/alternating.test: tests added
      * tests/core/neverclaimread.test: tests changed for
      new dot format
      * tests/core/readsave.test: tests changed
      * tests/core/sccdot.test: tests changed
      * tests/python/_altscc.ipynb: tests changed
      * tests/python/decompose.ipynb: tests changed
      f7bbfd28
    • Arthur Remaud's avatar
      autfilt: add option (y) to --dot to split universal transitions · 34859568
      Arthur Remaud authored
      Fixes #207
      
      * NEWS: Informations about the option 'y' for --dot added
      * bin/common_aoutput.cc: Documentation for the option 'y'
      for --dot added
      * spot/twaalgos/dot.cc (print_dst, process_link): Functions
      modified for the new option
      * tests/core/alternating.test: Tests added
      34859568
  14. 12 Feb, 2017 2 commits
    • Alexandre Duret-Lutz's avatar
      is_alternating() -> !is_existential() · fefb375d
      Alexandre Duret-Lutz authored
      Part of #212.
      
      * spot/misc/common.hh (SPOT_DEPRECATED): Improve support current
      compilers and options flags.
      * spot/twa/twagraph.hh, spot/graph/graph.hh (is_alternating): Mark it
      as deprecated.
      (is_existential): New method.
      * bin/autfilt.cc, bin/ltlcross.cc, spot/parseaut/parseaut.yy,
      spot/twa/twa.cc, spot/twa/twagraph.cc, spot/twaalgos/alternation.cc,
      spot/twaalgos/are_isomorphic.cc, spot/twaalgos/canonicalize.cc,
      spot/twaalgos/couvreurnew.cc, spot/twaalgos/cycles.cc,
      spot/twaalgos/degen.cc, spot/twaalgos/determinize.cc,
      spot/twaalgos/dot.cc, spot/twaalgos/dtbasat.cc,
      spot/twaalgos/dtwasat.cc, spot/twaalgos/hoa.cc,
      spot/twaalgos/isunamb.cc, spot/twaalgos/isweakscc.cc,
      spot/twaalgos/mask.hh, spot/twaalgos/minimize.cc,
      spot/twaalgos/postproc.cc, spot/twaalgos/product.cc,
      spot/twaalgos/randomize.cc, spot/twaalgos/remfin.cc,
      spot/twaalgos/sbacc.cc, spot/twaalgos/sccfilter.cc,
      spot/twaalgos/sccinfo.cc, spot/twaalgos/simulation.cc,
      spot/twaalgos/strength.cc, tests/core/graph.cc, tests/core/ngraph.cc,
      tests/python/alternating.py: Adjust all uses.
      * NEWS: Mention the renaming.
      fefb375d
    • Alexandre Duret-Lutz's avatar
      alternation: fix detection of non-weak automata · 15c6fd95
      Alexandre Duret-Lutz authored
      Fixes #218.
      
      * spot/twaalgos/alternation.cc: Adjust check.
      * tests/core/alternating.test: Add test case from #218.
      * NEWS: Mention the bug.
      15c6fd95
  15. 04 Feb, 2017 1 commit
  16. 02 Feb, 2017 1 commit
    • Maximilien Colange's avatar
      Rework the 'down_cast' macro, closing #196. · 3f547089
      Maximilien Colange authored
      * spot/misc/casts.hh: New inline functions and compile-time checks.
      * spot/kripke/kripkegraph.hh, spot/ta/taexplicit.cc,
        spot/ta/taproduct.cc, spot/ta/tgtaproduct.cc, spot/taalgos/tgba2ta.cc,
        spot/twa/taatgba.hh, spot/twa/taatgba.cc, spot/twa/twagraph.hh,
        spot/twa/twaproduct.cc, spot/twaalgos/emptiness.cc,
        spot/twaalgos/stutter.cc, spot/ltsmin/ltsmin.cc, tests/core/ikwiad.cc,
        tests/core/ngraph.cc: Remove downcast checks from code.
      3f547089
  17. 01 Feb, 2017 2 commits
  18. 18 Jan, 2017 1 commit
  19. 17 Jan, 2017 1 commit
    • Alexandre Duret-Lutz's avatar
      langmap: adjust to only color non-unique languages · 0ad62cb9
      Alexandre Duret-Lutz authored
      Fixes #203.
      
      * spot/twaalgos/langmap.hh (highlight_languages): Simplify the
      interface by only taking the automaton to color.
      * spot/twaalgos/langmap.cc (highlight_languages): Only introduce
      color for states that have a non-unique language.
      * tests/core/highlightstate.test: Update and add more tests.
      * tests/python/langmap.py: Keep the tests simple.
      * bin/autfilt.cc: Adjust usage and help string.
      0ad62cb9
  20. 14 Jan, 2017 2 commits
  21. 12 Jan, 2017 1 commit
    • Alexandre Duret-Lutz's avatar
      minimize_wdba: fix handling of input with useless SCCs · c9918f64
      Alexandre Duret-Lutz authored
      * spot/twaalgos/minimize.cc (minimize_wdba): Diminish the color of
      terminal SCCs that are incomplete, as if they had a non-accepting
      sink as successor.
      * spot/twaalgos/strength.hh, spot/twaalgos/strength.cc
      (is_terminal_automaton): Add an option to ignore trivial SCC as we did
      before, since it matters for deciding membership to the guarantee
      class.
      (is_safety_mwdba): Rewrite as ...
      (is_safety_automaton): ... generalizating to any acceptance, and
      ignoring trivial SCCs.
      * bin/ltlfilt.cc, python/ajax/spotcgi.in, spot/tl/hierarchy.cc,
      tests/core/ikwiad.cc: Adjust usage of is_terminal_automaton and
      is_safety_automaton().
      * tests/core/hierarchy.test: Add a problematic formula as test-case.
      * NEWS: Mention the bug.
      c9918f64
  22. 10 Jan, 2017 1 commit
    • Alexandre Duret-Lutz's avatar
      ltlfilt: add --recurrence and --persistence · de8a248f
      Alexandre Duret-Lutz authored
      * spot/twaalgos/remfin.cc, spot/twaalgos/remfin.hh
      (rabin_to_buchi_maybe): Make this function public.
      * bin/ltlfilt.cc: Implement the two options.
      * tests/core/hierarchy.test: New file.
      * tests/Makefile.am: Add it.
      * NEWS: Mention the new options.
      de8a248f
  23. 06 Jan, 2017 9 commits
    • Alexandre GBAGUIDI AISSE's avatar
      twaalgos: Set 'dicho' algo as default for SAT-based minimization · ef2355a5
      Alexandre GBAGUIDI AISSE authored
      * python/spot/__init__.py: Handle options.
      * spot/twaalgos/dtwasat.cc: Handle options.
      * spot/twaalgos/postproc.cc: Handle options.
      * spot/twaalgos/postproc.hh: Handle options.
      * tests/core/satmin.test: Update tests.
      Now use 'sat-minimize=4' to use the naive algo.
      * tests/core/satmin2.test: Update tests.
      Now use --sat-minimize='naive' to use the naive algo.
      * tests/python/satmin.py: Update tests.
      Now use 'naive=True' to use the naive algo.
      ef2355a5
    • Alexandre GBAGUIDI AISSE's avatar
      spot: Add 'langmap' option with dichotomy (it helps to choose min val) · 67e3a4f2
      Alexandre GBAGUIDI AISSE authored
      * python/spot/__init__.py: Handle 'dicho' option in 'sat_minimize'.
      * spot/priv/satcommon.cc: Implement get_number_of_distinct_vals.
      * spot/priv/satcommon.hh: Declare get_number_of_distinct_vals.
      * spot/twaalgos/dtbasat.cc: Use get_number_of_distinct_vals.
      * spot/twaalgos/dtbasat.hh: Change dichotomy function's prototype.
      * spot/twaalgos/dtwasat.cc: Use get_number_of_distinct_vals.
      * spot/twaalgos/dtwasat.hh: Change dichotomy function's prototype.
      Handle options.
      * spot/twaalgos/postproc.cc: Handle options.
      * spot/twaalgos/postproc.hh: Add dicho_langmap_ var for options.
      * tests/core/satmin2.test: Add tests for dichotomy.
      * tests/core/satmin.test: Add tests for dichotomy.
      * tests/python/satmin.py: Replace 'dichotomy' with 'dicho' option.
      67e3a4f2
    • Alexandre GBAGUIDI AISSE's avatar
      twaalgos: Implement language_map algo · 8a0eed6c
      Alexandre GBAGUIDI AISSE authored
      * python/spot/impl.i: Add python bindings.
      * spot/twaalgos/langmap.cc: Implement algo.
      * spot/twaalgos/langmap.hh: Declare algo.
      * spot/twaalgos/Makefile.am: Add new files.
      * tests/python/langmap.py: Add tests.
      * NEWS: Update.
      8a0eed6c
    • Alexandre GBAGUIDI AISSE's avatar
      spot: Implement dt*a_sat_minimize_assume(...) methods · 9a204b77
      Alexandre GBAGUIDI AISSE authored
      * python/spot/__init__.py: Add 'assume' option.
      * spot/misc/satsolver.cc: Add function to handle assumptions.
      * spot/misc/satsolver.hh: Declare assumption function.
      * spot/twaalgos/dtbasat.cc: Implement dtba_sat_minimize_assume.
      * spot/twaalgos/dtbasat.hh: Declare it.
      * spot/twaalgos/dtwasat.cc: Implement dtwa_sat_minimize_assume and
      handle options.
      * spot/twaalgos/dtwasat.hh: Declare it.
      * spot/twaalgos/postproc.cc: Handle options.
      * spot/twaalgos/postproc.hh: Use param_ var for incr and assume.
      * tests/core/satmin.test: Add tests for the new function.
      * tests/core/satmin2.test: Add tests for the new function.
      * tests/python/satmin.py: Add tests for the new function.
      9a204b77
    • Alexandre GBAGUIDI AISSE's avatar
      twaalgos: Implement dt*a_sat_minimize_incr(...) functions · ee17c2de
      Alexandre GBAGUIDI AISSE authored
      * python/spot/__init__.py: Add 'incr' boolean argument.
      * spot/twaalgos/dtbasat.cc: Implement dtba_sat_minimize_incr(...).
      * spot/twaalgos/dtbasat.hh: Declare it.
      * spot/twaalgos/dtwasat.cc: Implement dtwa_sat_minimize_incr(...) and
      deal with options.
      * spot/twaalgos/dtwasat.hh: Declare it.
      * spot/twaalgos/postproc.cc: Add option --sat-minimize=incr.
      * spot/twaalgos/postproc.hh: Add incr parameter.
      * tests/core/satmin.test: Add tests for incremental version.
      Update expected result.
      * tests/core/satmin2.test: Add tests for incremental version.
      * tests/python/satmin.py: Add tests for incremental version.
      ee17c2de
    • Alexandre GBAGUIDI AISSE's avatar
      twaalgos: Improve data storage in SAT-minimization · 9acd7370
      Alexandre GBAGUIDI AISSE authored
      * spot/misc/satsolver.hh: Make solver return vector<bool> instead of
      vector<int>.
      * spot/misc/satsolver.cc: Update code.
      * spot/priv/Makefile.am: Add satcommon.*
      * spot/priv/satcommon.hh: Declare helper class and factorize some
      duplicate code of dt*asat.cc
      * spot/priv/satcommon.cc: Implement helper class and factorize some
      duplicate code of dt*asat.cc
      * spot/twaalgos/dtbasat.cc: Declare helper, implement some functions
      in dict struct and update code.
      * spot/twaalgos/dtwasat.cc: Declare helper, implement some functions
      in dict struct and update code.
      * tests/core/readsat.cc: Update tests.
      * tests/core/satmin.test: Typo.
      * tests/core/satmin2.test: Update an expected result.
      9acd7370
    • Alexandre GBAGUIDI AISSE's avatar
      twaalgos: Help sat_build to ignore unuseful transitions · 79f4c8e0
      Alexandre GBAGUIDI AISSE authored
      * spot/twaalgos/dtbasat.cc: Fix static sat_build.
      * spot/twaalgos/dtwasat.cc: Fix static sat_build.
      79f4c8e0
    • Alexandre GBAGUIDI AISSE's avatar
      spot: Add Picosat to Spot library & Update satsolver class · 32f040fa
      Alexandre GBAGUIDI AISSE authored
      * Makefile.am: Add picosat to subdirs.
      * configure.ac: Add picosat/Makefile to AC_CONFIG_FILES.
      * README: Add picosat/ in the list of directories.
      * debian/copyright: Add picosat licence and details.
      * picosat/Makefile.am: Implement Makefile.am in picosat directory.
      * spot/Makefile.am: Tell the compiler to add libpico.la into libspot.la.
      * picosat/LICENSE: Add picosat licence.
      * picosat/NEWS: Add picosat NEWS.
      * picosat/VERSION: Add picosat VERSION.
      * picosat/picosat.c: Add picosat c file.
      * picosat/picosat.h: Add picosat header file.
      * spot/misc/satsolver.cc: Update functions.
      * spot/misc/satsolver.hh: Add documentation, clean code, change
      some functions visibility and separate templates functions.
      * spot/twaalgos/dtbasat.cc: Update dtba_to_sat function.
      * spot/twaalgos/dtwasat.cc: Update dtwa_to_sat function.
      32f040fa
    • Alexandre GBAGUIDI AISSE's avatar
      spot: Abstract cnf writing in SAT-based minimisation · 596bdec9
      Alexandre GBAGUIDI AISSE authored
      * spot/misc/satsolver.hh: Declare all functions needed.
      * spot/misc/satsolver.cc: Implement them.
      * spot/twaalgos/dtbasat.cc: Abstract writing.
      * spot/twaalgos/dtwasat.cc: Abstract writing.
      596bdec9
  24. 30 Dec, 2016 3 commits
    • Alexandre Duret-Lutz's avatar
      twa: add prop_set::improve_det · 684c9c47
      Alexandre Duret-Lutz authored
      Algorithms that remove transitions can turn a non-deterministic
      automaton into a deterministic one, so we need to be able to specify
      that determinism can be improved (as opposed to preserved).
      
      * spot/twa/twa.hh (twa::prop_set::improve_det): New attribute.
      (twa::prop_keep, twa::prop_copy): Honor it.
      * spot/tl/exclusive.cc, spot/twaalgos/alternation.cc,
      spot/twaalgos/complete.cc, spot/twaalgos/degen.cc,
      spot/twaalgos/determinize.cc, spot/twaalgos/mask.cc,
      spot/twaalgos/minimize.cc, spot/twaalgos/remfin.cc,
      spot/twaalgos/remprop.cc, spot/twaalgos/sbacc.cc,
      spot/twaalgos/sccfilter.cc, spot/twaalgos/simulation.cc,
      spot/twaalgos/strength.cc, spot/twaalgos/stutter.cc,
      spot/twaalgos/totgba.cc: Adjust calls to prop_keep() and
      prop_copy().
      684c9c47
    • Alexandre Duret-Lutz's avatar
      simulation: does not preserve !unambiguous, !semi-deterministic · ada81853
      Alexandre Duret-Lutz authored
      * spot/twaalgos/simulation.cc: Reset those to maybe.
      * tests/core/semidet.test: Add some tests.
      ada81853
    • Alexandre Duret-Lutz's avatar
      bedd96a7