1. 01 Jun, 2020 1 commit
    • Alexandre Duret-Lutz's avatar
      ltldo: improve error messages · b7abe6f4
      Alexandre Duret-Lutz authored
      Use ltldo:... instead of error:... and warning:... and also improve
      the diagnostic displayed after a translation failure to mention the
      tool and formula.
      
      Incidentally, this fixes a spurious test case failure observed by
      Philipp Schlehuber on CentOS7.7 where glibc 2.17 is installed.  With
      this system, when posix_spawn() starts a binary that does not exist,
      it returns success and let the child die with exit code 127.  On more
      recent glibc, posix_spawn() manages to return execve()'s errno, as if
      the child had not been created.  We handle those two different ways to
      fail, but before this patch one used to print "error:..." and the
      other "ltldo:...".
      
      * bin/ltldo.cc: Display the program_name in error message.  Display
      the command name and formula on translation failure.
      * tests/core/ltldo.test: Adjust test case.
      * NEWS: Mention the fix.
      b7abe6f4
  2. 30 May, 2020 1 commit
  3. 29 May, 2020 1 commit
  4. 25 May, 2020 1 commit
  5. 24 May, 2020 6 commits
  6. 23 May, 2020 2 commits
    • Alexandre Duret-Lutz's avatar
      simplify_acc: perform unit-propagation earlier · 49188715
      Alexandre Duret-Lutz authored
      Closes #405.   This shows no difference on the test suite,
      but that is thanks to the previous patch: without it, an
      example in automata.ipynb would have an extra edge.
      
      * spot/twaalgos/cleanacc.cc (simplify_acceptance): Call
      unit_propagation() before simplify_complementary_marks_here() and
      fuse_marks_here(), because that is simpler to perform.
      49188715
    • Alexandre Duret-Lutz's avatar
      remfin: do not clone transitions that are accepting in main · 6074202b
      Alexandre Duret-Lutz authored
      * spot/twaalgos/remfin.cc (default_strategy): Detect transitions
      from the main copy that are completely accepting and that do not
      need to be repeated in the clones.
      * tests/python/remfin.py: Add a test case.
      * tests/core/ltl2dstar4.test: Improve expected results.
      * NEWS: Mention the change.
      6074202b
  7. 22 May, 2020 2 commits
    • Alexandre Duret-Lutz's avatar
      improve fuse_marks_here by detecting more patterns · 260a141b
      Alexandre Duret-Lutz authored
      This remove some restrictions that prevented fuse_marks_here from
      simplifying certain patterns, as noted in the first comment of
      issue #405.
      
      * spot/twaalgos/cleanacc.cc (find_interm_rec, find_fusable): Remove
      some unnecessary restrictions to singleton marks, and replace the hack
      put one non-singleton mark at the beginning of the singleton list by a
      sort.
      * tests/python/simplacc.py: Add two test cases.
      * tests/python/automata.ipynb, tests/core/remfin.test: Improve
      expected results.
      * NEWS: Mention the bug.
      260a141b
    • Alexandre Duret-Lutz's avatar
      fixpool: allocate a new chunk on creation · 645935f7
      Alexandre Duret-Lutz authored
      Allocate the first chunk when the fixpool is created.  This avoid a
      undefined behavior reported in issue #413 without requiring an extra
      comparison in allocate().
      
      * spot/misc/fixpool.hh, spot/misc/fixpool.cc (new_chunk_): New method
      extracted from allocate().  Use it in the constructor as well.
      * NEWS: Mention the bug.
      645935f7
  8. 21 May, 2020 1 commit
    • Alexandre Duret-Lutz's avatar
      postproc: option to wdba-minimize only when sure · a0767e3c
      Alexandre Duret-Lutz authored
      Fixes #15.
      
      * spot/twaalgos/minimize.hh, spot/twaalgos/minimize.cc
      (minimize_obligation_garanteed_to_work): New function.
      * spot/twaalgos/postproc.hh, spot/twaalgos/postproc.cc: Use it if
      wdba-minimize=1.  Handle new default for wdba-minimize.
      * NEWS, bin/spot-x.cc: Document those changes.
      * tests/core/ltl2tgba2.test: Add some test cases.
      * tests/core/genltl.test: Improve expected results.
      a0767e3c
  9. 18 May, 2020 3 commits
    • Alexandre Duret-Lutz's avatar
    • Alexandre Duret-Lutz's avatar
      stats: speed up the computation of transitions · 208d0f78
      Alexandre Duret-Lutz authored
      Juraj Major reported a case with 32 APs where ltlcross would take
      forever to gather statistics.  It turns out that for each edge,
      twa_sub_statistics was enumerating all compatible assignments of 32
      APs.  This uses bdd_satcountset() instead, and also store the result
      in a long long to avoid overflows.
      
      * spot/twaalgos/stats.cc (twa_sub_statistics): Improve the code for
      counting transitions.
      * bin/common_aoutput.hh, bin/ltlcross.cc, spot/twaalgos/stats.hh:
      Store transition counts are long long.
      * tests/core/readsave.test: Add test case.
      * NEWS: Mention the bug.
      208d0f78
    • Alexandre Duret-Lutz's avatar
      [buddy] avoid cache errors in bdd_satcount() and friends · da96a509
      Alexandre Duret-Lutz authored
      * src/bddop.c (bdd_satcount, bdd_satcountln): If the number of
      declared variables changed since we last used it, reset misccache.
      Otherwise, bdd_satcount() and friends might return incorrect results
      after the number of variable is changed.  These is needed for the next
      patch in Spot to pass all tests.
      (misccache_varnum): New global variable to track that.
      (bdd_satcountset): Make sure that bdd_satcountset(bddtrue, bddtrue)
      return 1.0 and not 0.0.
      da96a509
  10. 16 May, 2020 3 commits
    • Alexandre Duret-Lutz's avatar
      ltlsynt: make sure the previous Xor optimization actually works · 66aa6d08
      Alexandre Duret-Lutz authored
      * spot/tl/simplify.hh, spot/tl/simplify.cc,
      spot/twaalgos/translate.cc: Update the tl_simplification
      options after all preferences have been given.
      * bin/ltlsynt.cc: Display the size of the translation output.
      * tests/core/ltlsynt.test: Add test case.
      66aa6d08
    • Alexandre Duret-Lutz's avatar
      translate: improve handling of Xor and Equiv at top-level for -G -D · 6bfa9793
      Alexandre Duret-Lutz authored
      * spot/tl/formula.hh: Add variant of formula::is that support 4
      arguments.
      * spot/tl/simplify.hh, spot/tl/simplify.cc: Add option keep_top_xor
      to preserve Xor and Equiv at the top-level.
      * spot/twaalgos/translate.cc: Adjust ltl-split to deal with Xor and
      Equiv for the -D -G case.
      * NEWS: Mention that.
      * tests/core/ltl2tgba2.test: Add test case.
      * tests/python/simstate.py: Adjust expected result.
      6bfa9793
    • Alexandre Duret-Lutz's avatar
      product: add product_xor() and product_xnor() · 3ab2dd17
      Alexandre Duret-Lutz authored
      * spot/twaalgos/product.cc, spot/twaalgos/product.hh: Add those
      functions.
      * tests/python/_product_weak.ipynb, tests/python/except.py: Test them.
      * NEWS: Mention them.
      3ab2dd17
  11. 30 Apr, 2020 5 commits
  12. 29 Apr, 2020 2 commits
    • Alexandre Duret-Lutz's avatar
      dot: fix #393 · a7051b32
      Alexandre Duret-Lutz authored
      * spot/twaalgos/dot.cc: Add support for option 'E', and default to
      rectangle nodes for large labels.
      * bin/common_aoutput.cc, NEWS: Document it.
      * tests/core/alternating.test, tests/core/dstar.test,
      tests/core/readsave.test, tests/core/sccdot.test,
      tests/core/tgbagraph.test, tests/python/_product_weak.ipynb,
      tests/python/alternation.ipynb, tests/python/atva16-fig2b.ipynb,
      tests/python/automata.ipynb, tests/python/decompose.ipynb,
      tests/python/gen.ipynb, tests/python/highlighting.ipynb,
      tests/python/ltsmin-dve.ipynb, tests/python/ltsmin-pml.ipynb,
      tests/python/parity.ipynb, tests/python/pdegen.py,
      tests/python/satmin.ipynb, tests/python/stutter-inv.ipynb: Adjust all
      test cases.
      a7051b32
    • Alexandre Duret-Lutz's avatar
      dot: fix #392 · 3ea63e9a
      Alexandre Duret-Lutz authored
      * spot/twaalgos/dot.cc: Add tooltips to "..." states and edges.
      * tests/core/readsave.test: Test this.
      * tests/python/highlighting.ipynb: Adjust.
      3ea63e9a
  13. 25 Apr, 2020 2 commits
    • Alexandre Duret-Lutz's avatar
      postproc: fix issue #402 · 67060420
      Alexandre Duret-Lutz authored
      * spot/twaalgos/postproc.cc, spot/twaalgos/postproc.hh,
      spot/twaalgos/translate.cc: Introduce a gen-reduce-parity option and
      use it on sub-automata built by ltl-split.
      * bin/spot-x.cc: Document it.
      * tests/core/ltl2tgba2.test: Add test case reported by Juraj Major.
      67060420
    • Alexandre Duret-Lutz's avatar
      ltlsynt: fix lar.old implementation · fe340ae8
      Alexandre Duret-Lutz authored
      * bin/ltlsynt.cc: Make sure to_parity_old() receive a deterministic
      automaton, for correctness.   Also call reduce_parity() afterward,
      to match what was done in 2.8.7.
      * tests/core/ltlsynt.test: Include lar.old in the comparison of all
      results to make sure it give the same result as the other 3
      algorithms.
      fe340ae8
  14. 20 Apr, 2020 1 commit
  15. 19 Apr, 2020 2 commits
    • Alexandre Duret-Lutz's avatar
      192ca910
    • Alexandre Duret-Lutz's avatar
      avoid mark_t::count() when possible · cc12d514
      Alexandre Duret-Lutz authored
      count() may be implemented using a loop, so using it touch
      check count() == 1 or count() > 1 is not advisable.
      
      * spot/twa/acc.hh (mark_t::is_singleton, mark_t::has_many): Introduce
      these two methods to replace count()==1 and count()>1
      * spot/twa/acc.cc, spot/twaalgos/cleanacc.cc,
      spot/twaalgos/determinize.cc, spot/twaalgos/dtwasat.cc,
      spot/twaalgos/iscolored.cc, spot/twaalgos/remfin.cc,
      spot/twaalgos/toparity.cc: Adjust usage.
      cc12d514
  16. 18 Apr, 2020 4 commits
  17. 17 Apr, 2020 3 commits
    • Alexandre Duret-Lutz's avatar
      to_parity: only call reduce_parity() when prefix_parity is enabled · fd0d752b
      Alexandre Duret-Lutz authored
      Calling reduce_parity() in to_parity() is confusing, because then
      running to_parity() on one SCC does not necessarily produce the same
      output as running to_parity() on the entire automaton.  However it is
      necessary for the implementation of parity_prefix.  As a compromise,
      disable reduce_parity() when parity_prefix is disabled, this way we
      can use that to demonstrate how the algorithm works.
      
      * spot/twaalgos/toparity.hh, spot/twaalgos/toparity.cc: Do not
      call reduce_parity() when parity_prefix is disabled.
      * tests/python/toparity.py: Adjust.
      fd0d752b
    • Alexandre Duret-Lutz's avatar
      simplify_acc: loop over the simplifications · 102ef043
      Alexandre Duret-Lutz authored
      * spot/twaalgos/cleanacc.cc (simplify_acceptance_here): Run the
      simplifications in a loop until the condition does not change anymore.
      * tests/python/simplacc.py, tests/core/accsimpl.test,
      tests/core/remfin.test, tests/python/merge.py,
      tests/python/simplacc.py, tests/python/toparity.py: Update expected
      results.
      * tests/python/automata.ipynb: Update the failing example to a more
      interesting one, matching the one in doc/org/autfilt.org.
      102ef043
    • Alexandre Duret-Lutz's avatar
      simplify_acc: fix an infinite loop · b62e1bb1
      Alexandre Duret-Lutz authored
      * spot/twaalgos/cleanacc.cc (fuse_mark_here): Fix incorrect cancelling
      of n-ary subterms, causing an invalid acceptance condition, and then
      an infinite loop.
      * tests/python/simplacc.py: Add test case.
      b62e1bb1