Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
Spot
Spot
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 117
    • Issues 117
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Spot
  • SpotSpot
  • Issues
  • #235

Closed
Open
Opened Feb 27, 2017 by Alexandre Duret-Lutz@adlOwner

spot.ltsmin.require('divine') should check the exit status

Currently it does

            if shutil.which("divine") == None:
                print("divine not available", file=sys.stderr)
                sys.exit(77)
            out = subprocess.check_output(['divine', 'compile', '--help'],
                                          stderr=subprocess.STDOUT)
            if b'LTSmin' not in out:
                print("divine available but no support for LTSmin",
                       file=sys.stderr)
                sys.exit(77)

However if divine compile --help terminates with a non-zero exit code (as in the current version of divine), this triggers an exception and that causes our tests to fail instead of being skipped.

Reported by @xlauko.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
spot 2.3.2
Milestone
spot 2.3.2
Assign milestone
Time tracking
None
Due date
None
Reference: spot/spot#235